github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8701] fix(oauth-provider): fix dist declaration type errors #16404

New Issue
Closed
opened 2026-04-13 10:30:49 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 10:30:49 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/better-auth/better-auth/pull/8701

State: closed
Merged: Yes

Summary

The oauth-provider package has 8 type errors in its emitted .d.mts declarations that are invisible during development but break external consumers. This PR fixes them and adds CI validation to prevent regressions.

Why these errors are hidden

The monorepo uses customConditions: ["dev-source"] in tsconfig.base.json, which resolves workspace imports to source .ts files instead of built dist/ output:

// tsconfig.base.json
"customConditions": ["dev-source"]

Each package exports a dev-source condition:

"dev-source": "./src/index.ts"

So pnpm typecheck (root tsc --build) resolves all cross-package imports to source — types are always consistent. But the published dist declarations have real type issues.

Scenario What TypeScript sees Result
Root tsc --build Source .ts via dev-source Passes
Package-level tsc --noEmit Source with dist deps (no build mode) 8 errors
External consumer via npm Dist .d.mts files Broken types

Commit 1: Fix the 8 type errors

  1. client-resource.ts (5 errors) — auth?.options.baseURL typed as BaseURLConfig (includes DynamicBaseURLConfig) in dist. Fix: narrow to string | undefined with a typeof check.

  2. consent.ts (1 error) — ctx.context.postLogin doesn't exist on dist AuthContext (dynamically added at runtime). Fix: cast to Record<string, unknown>.

  3. register.ts (1 error) — redirect_uris typed as string[] | undefined in dist, assigned to string[]. Fix: default to [].

  4. utils/index.ts (1 error) — BetterAuthError("jwt_config", "jwt plugin not found") — second arg is a string but constructor expects { cause?: unknown }. Silently ignored at runtime. Fix: drop invalid second arg.

Commit 2: Add dist declaration CI check

Adds tsconfig.dist-check.json at the repo root that:

  • Clears customConditions (disables dev-source resolution)
  • Sets composite: false + noEmit: true
  • Includes all downstream package sources, excluding better-auth, core, and electron (top-level packages that can't be dist-checked against themselves due to module augmentation conflicts)

Available locally via pnpm typecheck:dist and runs in CI after the build step.

How to reproduce

pnpm build
pnpm typecheck:dist  # Should pass (0 errors with this PR)

# Without this PR's fixes:
git stash
pnpm typecheck:dist  # Shows 8 oauth-provider errors

Test plan

  • pnpm typecheck (root, dev-source) still passes
  • pnpm lint passes
  • pnpm typecheck:dist — 0 errors (was 8)
  • 216/216 oauth-provider tests pass
**Original Pull Request:** https://github.com/better-auth/better-auth/pull/8701 **State:** closed **Merged:** Yes --- ## Summary The `oauth-provider` package has **8 type errors** in its emitted `.d.mts` declarations that are invisible during development but break external consumers. This PR fixes them and adds CI validation to prevent regressions. ### Why these errors are hidden The monorepo uses `customConditions: ["dev-source"]` in `tsconfig.base.json`, which resolves workspace imports to **source `.ts` files** instead of built `dist/` output: ```jsonc // tsconfig.base.json "customConditions": ["dev-source"] ``` Each package exports a `dev-source` condition: ```json "dev-source": "./src/index.ts" ``` So `pnpm typecheck` (root `tsc --build`) resolves all cross-package imports to source — types are always consistent. **But the published dist declarations have real type issues.** | Scenario | What TypeScript sees | Result | |---|---|---| | Root `tsc --build` | Source `.ts` via dev-source | Passes | | Package-level `tsc --noEmit` | Source with dist deps (no build mode) | **8 errors** | | External consumer via npm | Dist `.d.mts` files | **Broken types** | ### Commit 1: Fix the 8 type errors 1. **`client-resource.ts`** (5 errors) — `auth?.options.baseURL` typed as `BaseURLConfig` (includes `DynamicBaseURLConfig`) in dist. **Fix:** narrow to `string | undefined` with a `typeof` check. 2. **`consent.ts`** (1 error) — `ctx.context.postLogin` doesn't exist on dist `AuthContext` (dynamically added at runtime). **Fix:** cast to `Record<string, unknown>`. 3. **`register.ts`** (1 error) — `redirect_uris` typed as `string[] | undefined` in dist, assigned to `string[]`. **Fix:** default to `[]`. 4. **`utils/index.ts`** (1 error) — `BetterAuthError("jwt_config", "jwt plugin not found")` — second arg is a string but constructor expects `{ cause?: unknown }`. Silently ignored at runtime. **Fix:** drop invalid second arg. ### Commit 2: Add dist declaration CI check Adds `tsconfig.dist-check.json` at the repo root that: - Clears `customConditions` (disables `dev-source` resolution) - Sets `composite: false` + `noEmit: true` - Includes all downstream package sources, excluding `better-auth`, `core`, and `electron` (top-level packages that can't be dist-checked against themselves due to module augmentation conflicts) Available locally via `pnpm typecheck:dist` and runs in CI after the build step. ### How to reproduce ```bash pnpm build pnpm typecheck:dist # Should pass (0 errors with this PR) # Without this PR's fixes: git stash pnpm typecheck:dist # Shows 8 oauth-provider errors ``` ## Test plan - [x] `pnpm typecheck` (root, dev-source) still passes - [x] `pnpm lint` passes - [x] `pnpm typecheck:dist` — 0 errors (was 8) - [x] 216/216 oauth-provider tests pass
GiteaMirror added the pull-request label 2026-04-13 10:30:49 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#16404
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?