github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-30 10:56:31 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8647] fix(sso): read SAML InResponseTo from correct path #16363

New Issue
Open
opened 2026-04-13 10:30:13 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 10:30:13 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/better-auth/better-auth/pull/8647

State: open
Merged: No

Summary

  • Fix SAML InResponseTo validation that always fails when enableInResponseToValidation is enabled
  • samlify's extractor nests InResponseTo under extract.response, but the two login handlers read extract.inResponseTo (always undefined)
  • The logout handler already used the correct path extract?.response?.inResponseTo

Closes #8607
Closes #8608

Test plan

  • Enable enableInResponseToValidation with allowIdpInitiated: false
  • Initiate SP-initiated SAML login — should now succeed instead of being rejected
**Original Pull Request:** https://github.com/better-auth/better-auth/pull/8647 **State:** open **Merged:** No --- ## Summary - Fix SAML InResponseTo validation that always fails when `enableInResponseToValidation` is enabled - `samlify`'s extractor nests `InResponseTo` under `extract.response`, but the two login handlers read `extract.inResponseTo` (always `undefined`) - The logout handler already used the correct path `extract?.response?.inResponseTo` Closes #8607 Closes #8608 ## Test plan - Enable `enableInResponseToValidation` with `allowIdpInitiated: false` - Initiate SP-initiated SAML login — should now succeed instead of being rejected
GiteaMirror added the pull-request label 2026-04-13 10:30:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#16363
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?