github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8646] fix(scim): return 204 instead of 400 for no-op PATCH requests #16362

New Issue
Closed
opened 2026-04-13 10:30:12 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 10:30:12 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/better-auth/better-auth/pull/8646

State: closed
Merged: No

Summary

  • Per RFC 7644, a SCIM PATCH request that results in no changes (e.g., value already exists, unknown fields, empty operations) should return 204 No Content instead of 400 Bad Request.
  • This fixes issues where identity providers (IDPs) send patch requests on users whose data is already up-to-date, which previously caused spurious 400 errors.
  • Updated 3 related tests to expect 204 success instead of 400 errors.

Closes #8549

Test plan

  • All 19 tests in packages/scim/src/scim-patch.test.ts pass
  • Build succeeds
**Original Pull Request:** https://github.com/better-auth/better-auth/pull/8646 **State:** closed **Merged:** No --- ## Summary - Per RFC 7644, a SCIM PATCH request that results in no changes (e.g., value already exists, unknown fields, empty operations) should return **204 No Content** instead of **400 Bad Request**. - This fixes issues where identity providers (IDPs) send patch requests on users whose data is already up-to-date, which previously caused spurious 400 errors. - Updated 3 related tests to expect 204 success instead of 400 errors. Closes #8549 ## Test plan - [x] All 19 tests in `packages/scim/src/scim-patch.test.ts` pass - [x] Build succeeds
GiteaMirror added the pull-request label 2026-04-13 10:30:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#16362
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?