github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8644] fix(oauth-provider): handle dynamic baseURL config in init #16360

New Issue
Closed
opened 2026-04-13 10:30:10 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 10:30:10 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/better-auth/better-auth/pull/8644

State: closed
Merged: No

Summary

  • The oauth-provider plugin's init() function crashes with TypeError: Invalid URL when baseURL uses the object format { allowedHosts, protocol } instead of a string, because ctx.baseURL is an empty string during initialization (it's only resolved per-request).
  • Wraps new URL(issuer) in a try/catch so that init gracefully skips warnings when the URL can't be parsed.

Fixes #8559

Test plan

  • Verify that configuring baseURL as an object (e.g., { allowedHosts: ["example.com"], protocol: "https" }) no longer crashes the oauth-provider plugin during initialization.
  • Verify that string-based baseURL configurations continue to work as before (init warnings are still shown).
**Original Pull Request:** https://github.com/better-auth/better-auth/pull/8644 **State:** closed **Merged:** No --- ## Summary - The oauth-provider plugin's `init()` function crashes with `TypeError: Invalid URL` when `baseURL` uses the object format `{ allowedHosts, protocol }` instead of a string, because `ctx.baseURL` is an empty string during initialization (it's only resolved per-request). - Wraps `new URL(issuer)` in a try/catch so that init gracefully skips warnings when the URL can't be parsed. Fixes #8559 ## Test plan - Verify that configuring `baseURL` as an object (e.g., `{ allowedHosts: ["example.com"], protocol: "https" }`) no longer crashes the oauth-provider plugin during initialization. - Verify that string-based `baseURL` configurations continue to work as before (init warnings are still shown).
GiteaMirror added the pull-request label 2026-04-13 10:30:10 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#16360
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?