github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 08:01:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8643] fix(sso): read SAML InResponseTo from correct path #16359

New Issue
Closed
opened 2026-04-13 10:30:09 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 10:30:09 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/better-auth/better-auth/pull/8643

State: closed
Merged: No

Summary

  • Fix SAML InResponseTo validation always failing because the value was read from the wrong path on samlify's extract result
  • samlify's extractor nests InResponseTo under extract.response.inResponseTo, but the login callback (callbackSSOSAML) and ACS endpoint (acsEndpoint) were reading extract.inResponseTo, which is always undefined
  • The logout handler already reads from the correct path (extract?.response?.inResponseTo), confirming the correct structure

Fixes #8607

Test plan

  • Verify SAML SSO login with enableInResponseToValidation enabled no longer fails with "InResponseTo mismatch" errors
  • Verify IdP-initiated SAML login still works when allowIdpInitiated is true
  • Verify the ACS endpoint also correctly validates InResponseTo when enabled
**Original Pull Request:** https://github.com/better-auth/better-auth/pull/8643 **State:** closed **Merged:** No --- ## Summary - Fix SAML `InResponseTo` validation always failing because the value was read from the wrong path on samlify's extract result - samlify's extractor nests `InResponseTo` under `extract.response.inResponseTo`, but the login callback (`callbackSSOSAML`) and ACS endpoint (`acsEndpoint`) were reading `extract.inResponseTo`, which is always `undefined` - The logout handler already reads from the correct path (`extract?.response?.inResponseTo`), confirming the correct structure Fixes #8607 ## Test plan - [ ] Verify SAML SSO login with `enableInResponseToValidation` enabled no longer fails with "InResponseTo mismatch" errors - [ ] Verify IdP-initiated SAML login still works when `allowIdpInitiated` is true - [ ] Verify the ACS endpoint also correctly validates `InResponseTo` when enabled
GiteaMirror added the pull-request label 2026-04-13 10:30:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#16359
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?