github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 08:01:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8586] feat(magic-link): add server-only generateMagicLink API #16327

New Issue
Open
opened 2026-04-13 10:29:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 10:29:40 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/better-auth/better-auth/pull/8586

State: open
Merged: No

Context

  • this PR is the follow-up created from the feedback on #8572
  • instead of returning the token from the existing HTTP/client sign-in flow, this version adds a separate server-only auth.api.generateMagicLink() API
  • a follow-up fix restores declared callback route paths in auth hooks so existing /callback/:id matchers keep working

Summary

  • add a separate server-only auth.api.generateMagicLink() that returns { status, url, token }
  • keep authClient.signIn.magicLink() and auth.api.signInMagicLink() status-only and still call sendMagicLink
  • share the issuance logic between the server-only and HTTP flows
  • preserve declared endpoint paths like /callback/:id while still giving pathless server-only endpoints a string hook path
  • document the new server helper and add regression coverage for both server parity and routed hook paths

Validation

  • pnpm exec vitest run packages/better-auth/src/plugins/magic-link/magic-link.test.ts
  • pnpm exec vitest run packages/better-auth/src/api/to-auth-endpoints.test.ts
  • pnpm exec vitest run packages/better-auth/src/social.test.ts
  • pnpm exec vitest run packages/better-auth/src/plugins/oauth-proxy/oauth-proxy.test.ts (callback/state regressions pass locally; the Postgres-backed UUID case requires the repo Docker setup)
  • pnpm exec vitest run packages/better-auth/src/api/routes/account.test.ts
  • pnpm exec vitest run packages/better-auth/src/oauth2/link-account.test.ts
**Original Pull Request:** https://github.com/better-auth/better-auth/pull/8586 **State:** open **Merged:** No --- ## Context - this PR is the follow-up created from the feedback on #8572 - instead of returning the token from the existing HTTP/client sign-in flow, this version adds a separate server-only `auth.api.generateMagicLink()` API - a follow-up fix restores declared callback route paths in auth hooks so existing `/callback/:id` matchers keep working ## Summary - add a separate server-only `auth.api.generateMagicLink()` that returns `{ status, url, token }` - keep `authClient.signIn.magicLink()` and `auth.api.signInMagicLink()` status-only and still call `sendMagicLink` - share the issuance logic between the server-only and HTTP flows - preserve declared endpoint paths like `/callback/:id` while still giving pathless server-only endpoints a string hook path - document the new server helper and add regression coverage for both server parity and routed hook paths ## Validation - `pnpm exec vitest run packages/better-auth/src/plugins/magic-link/magic-link.test.ts` - `pnpm exec vitest run packages/better-auth/src/api/to-auth-endpoints.test.ts` - `pnpm exec vitest run packages/better-auth/src/social.test.ts` - `pnpm exec vitest run packages/better-auth/src/plugins/oauth-proxy/oauth-proxy.test.ts` (callback/state regressions pass locally; the Postgres-backed UUID case requires the repo Docker setup) - `pnpm exec vitest run packages/better-auth/src/api/routes/account.test.ts` - `pnpm exec vitest run packages/better-auth/src/oauth2/link-account.test.ts`
GiteaMirror added the pull-request label 2026-04-13 10:29:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#16327
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?