github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8567] fix: resolve duplicate operationId in admin plugin endpoints #16313

New Issue
Closed
opened 2026-04-13 10:29:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 10:29:27 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/better-auth/better-auth/pull/8567

State: closed
Merged: No

Summary

Fixes duplicate operationId values in the OpenAPI schema that cause code generation tools (like Orval) to produce TypeScript errors (TS2300: Duplicate identifier).

Changes:

  • listUserSessions → adminListUserSessions (for /admin/list-user-sessions)
  • updateUser → adminUpdateUser (for /admin/update-user)

Problem

The admin plugin endpoints shared the same operationId as core endpoints:

Endpoint Old operationId New operationId
/admin/list-user-sessions (POST) listUserSessions adminListUserSessions
/admin/update-user (POST) updateUser adminUpdateUser

This violated the OpenAPI 3.0 spec which requires unique operationIds across all operations.

Test Plan

  • Generate OpenAPI schema with admin plugin enabled
  • Verify no duplicate operationIds exist
  • Run Orval or similar code generator to confirm no TS2300 errors

Fixes #8558

This PR was created with AI assistance. The fix follows the same pattern established in PR #6203.

Made with Cursor

Summary by cubic

Fixes duplicate operationId values in the OpenAPI schema for admin plugin endpoints to prevent codegen collisions (e.g., TS2300: Duplicate identifier) in tools like orval. Ensures each operation has a unique operationId per OpenAPI 3.0.

  • Bug Fixes
    • /admin/list-user-sessions (POST): operationId listUserSessions → adminListUserSessions
    • /admin/update-user (POST): operationId updateUser → adminUpdateUser

Written for commit bbaa588e85. Summary will update on new commits.

**Original Pull Request:** https://github.com/better-auth/better-auth/pull/8567 **State:** closed **Merged:** No --- ## Summary Fixes duplicate `operationId` values in the OpenAPI schema that cause code generation tools (like Orval) to produce TypeScript errors (`TS2300: Duplicate identifier`). **Changes:** - `listUserSessions` → `adminListUserSessions` (for `/admin/list-user-sessions`) - `updateUser` → `adminUpdateUser` (for `/admin/update-user`) ## Problem The admin plugin endpoints shared the same `operationId` as core endpoints: | Endpoint | Old operationId | New operationId | |----------|-----------------|-----------------| | `/admin/list-user-sessions` (POST) | `listUserSessions` | `adminListUserSessions` | | `/admin/update-user` (POST) | `updateUser` | `adminUpdateUser` | This violated the [OpenAPI 3.0 spec](https://swagger.io/docs/specification/v3_0/paths-and-operations/#operationid) which requires unique operationIds across all operations. ## Test Plan - [ ] Generate OpenAPI schema with admin plugin enabled - [ ] Verify no duplicate operationIds exist - [ ] Run Orval or similar code generator to confirm no TS2300 errors Fixes #8558 --- *This PR was created with AI assistance. The fix follows the same pattern established in PR #6203.* Made with [Cursor](https://cursor.com) <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fixes duplicate `operationId` values in the OpenAPI schema for admin plugin endpoints to prevent codegen collisions (e.g., `TS2300: Duplicate identifier`) in tools like `orval`. Ensures each operation has a unique `operationId` per OpenAPI 3.0. - **Bug Fixes** - `/admin/list-user-sessions` (POST): `operationId` `listUserSessions` → `adminListUserSessions` - `/admin/update-user` (POST): `operationId` `updateUser` → `adminUpdateUser` <sup>Written for commit bbaa588e85eaa924cea1cc4d818b47ea924bc091. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. -->
GiteaMirror added the pull-request label 2026-04-13 10:29:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#16313
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?