github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8555] chore: mark third-party peerDependencies as optional in adapter packages #16306

New Issue
Closed
opened 2026-04-13 10:29:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 10:29:20 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/better-auth/better-auth/pull/8555

State: closed
Merged: Yes

Summary

  • Mark mongodb as optional peer in @better-auth/mongo-adapter
  • Mark kysely as optional peer in @better-auth/kysely-adapter
  • Mark ioredis as optional peer in @better-auth/redis-storage

These packages are dependencies of the main better-auth package (for re-export paths like better-auth/adapters/mongodb). Without peerDependenciesMeta: { optional: true }, package managers warn about or auto-install mongodb, kysely, and ioredis for all better-auth users, even if they don't use those adapters.

prisma-adapter and drizzle-adapter already had this set correctly.

Test plan

  • Verify pnpm install does not pull in mongodb, kysely, or ioredis unless explicitly installed by the user
**Original Pull Request:** https://github.com/better-auth/better-auth/pull/8555 **State:** closed **Merged:** Yes --- ## Summary - Mark `mongodb` as optional peer in `@better-auth/mongo-adapter` - Mark `kysely` as optional peer in `@better-auth/kysely-adapter` - Mark `ioredis` as optional peer in `@better-auth/redis-storage` These packages are dependencies of the main `better-auth` package (for re-export paths like `better-auth/adapters/mongodb`). Without `peerDependenciesMeta: { optional: true }`, package managers warn about or auto-install `mongodb`, `kysely`, and `ioredis` for all `better-auth` users, even if they don't use those adapters. `prisma-adapter` and `drizzle-adapter` already had this set correctly. ## Test plan - [ ] Verify `pnpm install` does not pull in `mongodb`, `kysely`, or `ioredis` unless explicitly installed by the user
GiteaMirror added the pull-request label 2026-04-13 10:29:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#16306
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?