github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8449] [MERGED] chore(adapters): mark ORM peer dependencies as optional #16228

New Issue
Closed
opened 2026-04-13 10:27:08 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 10:27:08 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8449
Author: @himself65
Created: 3/6/2026
Status: ✅ Merged
Merged: 3/6/2026
Merged by: @himself65

Base: canary ← Head: chore/optional-peer-deps-adapters

📝 Commits (2)

  • 3f124d6 chore(adapters): mark ORM peer dependencies as optional
  • 64e5ef1 fix(lint): add drizzle-orm to knip ignoreDependencies for drizzle-adapter

📊 Changes

3 files changed (+16 additions, -0 deletions)

View changed files

📝 knip.jsonc (+3 -0)
📝 packages/drizzle-adapter/package.json (+5 -0)
📝 packages/prisma-adapter/package.json (+8 -0)

📄 Description

Summary

  • Mark @prisma/client and prisma as optional peer deps in @better-auth/prisma-adapter
  • Mark drizzle-orm as optional peer dep in @better-auth/drizzle-adapter

This suppresses peer dependency warnings when these ORM packages are not directly installed by the consumer.

Test plan

  • Verify pnpm install works without warnings
  • Verify adapters still function correctly when ORM packages are installed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8449 **Author:** [@himself65](https://github.com/himself65) **Created:** 3/6/2026 **Status:** ✅ Merged **Merged:** 3/6/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `chore/optional-peer-deps-adapters` --- ### 📝 Commits (2) - [`3f124d6`](https://github.com/better-auth/better-auth/commit/3f124d6fe5943983c5fd5255f91ab18fb692d507) chore(adapters): mark ORM peer dependencies as optional - [`64e5ef1`](https://github.com/better-auth/better-auth/commit/64e5ef152d3b8f61f4b60c88984c833128e9ff93) fix(lint): add drizzle-orm to knip ignoreDependencies for drizzle-adapter ### 📊 Changes **3 files changed** (+16 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `knip.jsonc` (+3 -0) 📝 `packages/drizzle-adapter/package.json` (+5 -0) 📝 `packages/prisma-adapter/package.json` (+8 -0) </details> ### 📄 Description ## Summary - Mark `@prisma/client` and `prisma` as optional peer deps in `@better-auth/prisma-adapter` - Mark `drizzle-orm` as optional peer dep in `@better-auth/drizzle-adapter` This suppresses peer dependency warnings when these ORM packages are not directly installed by the consumer. ## Test plan - [ ] Verify `pnpm install` works without warnings - [ ] Verify adapters still function correctly when ORM packages are installed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 10:27:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#16228
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?