github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8399] [CLOSED] [WIP] Add regression test for pre-parsed form-urlencoded token body #16198

New Issue
Closed
opened 2026-04-13 10:26:13 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 10:26:13 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8399
Author: @Copilot
Created: 3/4/2026
Status: ❌ Closed

Base: 2026-02-17/test/oauth-token-form-urlencoded-regression ← Head: copilot/sub-pr-8019

📝 Commits (1)

📄 Description

Thanks for the feedback on #8019. I've created this new PR, which merges into #8019, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress.

Original PR: #8019
Triggering comment (https://github.com/better-auth/better-auth/pull/8019#issuecomment-4001001270):

@copilot revert pnpm-lock file changes

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Summary by cubic

Add a regression test to ensure the OAuth /token endpoint correctly handles pre-parsed application/x-www-form-urlencoded bodies (e.g., when upstream middleware parses the request). Reverts unintended pnpm-lock changes from #8019 to keep dependencies untouched.

Written for commit 754d59c6c0. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8399 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 3/4/2026 **Status:** ❌ Closed **Base:** `2026-02-17/test/oauth-token-form-urlencoded-regression` ← **Head:** `copilot/sub-pr-8019` --- ### 📝 Commits (1) - [`754d59c`](https://github.com/better-auth/better-auth/commit/754d59c6c0d923da60785fe2d5b33d5d340c2a75) Initial plan ### 📄 Description Thanks for the feedback on #8019. I've created this new PR, which merges into #8019, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress. Original PR: #8019 Triggering comment (https://github.com/better-auth/better-auth/pull/8019#issuecomment-4001001270): > @copilot revert pnpm-lock file changes <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Add a regression test to ensure the OAuth /token endpoint correctly handles pre-parsed application/x-www-form-urlencoded bodies (e.g., when upstream middleware parses the request). Reverts unintended pnpm-lock changes from #8019 to keep dependencies untouched. <sup>Written for commit 754d59c6c0d923da60785fe2d5b33d5d340c2a75. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 10:26:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#16198
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?