github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 08:01:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8135] [MERGED] fix(last-login-method): tracks magic-link auth by default #16015

New Issue
Closed
opened 2026-04-13 10:21:04 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 10:21:04 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8135
Author: @simonfelding
Created: 2/24/2026
Status: ✅ Merged
Merged: 2/28/2026
Merged by: @Bekacru

Base: canary ← Head: fix-last-login-method-magic-link-reference

📝 Commits (3)

  • e6cbbd4 fix: last-login-method tracks magic-link auth by default
  • 457edfc revert
  • 9663b84 test: add test coverage

📊 Changes

2 files changed (+109 additions, -0 deletions)

View changed files

📝 packages/better-auth/src/plugins/last-login-method/index.ts (+1 -0)
📝 packages/better-auth/src/plugins/last-login-method/last-login-method.test.ts (+108 -0)

📄 Description

last-login method should track magic-link authentication by default. I don't see anywhere in the docs why it shouldnt :)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8135 **Author:** [@simonfelding](https://github.com/simonfelding) **Created:** 2/24/2026 **Status:** ✅ Merged **Merged:** 2/28/2026 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `fix-last-login-method-magic-link-reference` --- ### 📝 Commits (3) - [`e6cbbd4`](https://github.com/better-auth/better-auth/commit/e6cbbd465ccc861d53a62f1e70d0426a1379f27f) fix: last-login-method tracks magic-link auth by default - [`457edfc`](https://github.com/better-auth/better-auth/commit/457edfcd74c05b8c38343f938c6b0dd222ef2a36) revert - [`9663b84`](https://github.com/better-auth/better-auth/commit/9663b849836d6fec03cef92cb11d77fef90d2ab6) test: add test coverage ### 📊 Changes **2 files changed** (+109 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/last-login-method/index.ts` (+1 -0) 📝 `packages/better-auth/src/plugins/last-login-method/last-login-method.test.ts` (+108 -0) </details> ### 📄 Description last-login method should track magic-link authentication by default. I don't see anywhere in the docs why it shouldnt :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 10:21:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#16015
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?