github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7979] [MERGED] test: check client output #15912

New Issue
Closed
opened 2026-04-13 10:18:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 10:18:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7979
Author: @himself65
Created: 2/15/2026
Status: ✅ Merged
Merged: 2/15/2026
Merged by: @himself65

Base: canary ← Head: himself65/2026/02/15/esbuild

📝 Commits (2)

📊 Changes

5 files changed (+56 additions, -4 deletions)

View changed files

📝 e2e/smoke/test/esbuild.spec.ts (+34 -0)
➕ e2e/smoke/test/fixtures/esbuild/src/client.ts (+7 -0)
📝 e2e/smoke/test/fixtures/vite/src/client.ts (+2 -1)
📝 e2e/smoke/test/vite.spec.ts (+10 -0)
📝 packages/better-auth/src/client/types.ts (+3 -3)

📄 Description

Related: https://github.com/better-auth/better-auth/issues/6213

Summary by cubic

Keep the client bundle free of Zod runtime across esbuild and Vite builds by tightening client type imports and expanding e2e checks. Fixes #6213.

  • Bug Fixes
    • Updated client type imports to use @better-auth/core/db and ../db/field to avoid server-only code in client builds.
    • Added smoke tests for esbuild and Vite that bundle a minimal client (updated fixtures) and assert the output excludes ZodString and ZodObject, and server-only imports.

Written for commit cf5fb6b7a1. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7979 **Author:** [@himself65](https://github.com/himself65) **Created:** 2/15/2026 **Status:** ✅ Merged **Merged:** 2/15/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2026/02/15/esbuild` --- ### 📝 Commits (2) - [`0dbea13`](https://github.com/better-auth/better-auth/commit/0dbea1320a76e37573b3f83216a05247d3e1c42b) test: check client output - [`cf5fb6b`](https://github.com/better-auth/better-auth/commit/cf5fb6b7a13bd0d86ec9083a9102b1da1157b8eb) test: fix ### 📊 Changes **5 files changed** (+56 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `e2e/smoke/test/esbuild.spec.ts` (+34 -0) ➕ `e2e/smoke/test/fixtures/esbuild/src/client.ts` (+7 -0) 📝 `e2e/smoke/test/fixtures/vite/src/client.ts` (+2 -1) 📝 `e2e/smoke/test/vite.spec.ts` (+10 -0) 📝 `packages/better-auth/src/client/types.ts` (+3 -3) </details> ### 📄 Description Related: https://github.com/better-auth/better-auth/issues/6213 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Keep the client bundle free of Zod runtime across esbuild and Vite builds by tightening client type imports and expanding e2e checks. Fixes #6213. - **Bug Fixes** - Updated client type imports to use @better-auth/core/db and ../db/field to avoid server-only code in client builds. - Added smoke tests for esbuild and Vite that bundle a minimal client (updated fixtures) and assert the output excludes ZodString and ZodObject, and server-only imports. <sup>Written for commit cf5fb6b7a13bd0d86ec9083a9102b1da1157b8eb. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 10:18:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#15912
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?