github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7478] [MERGED] fix: include Set-Cookie when APIError thrown in hooks #15588

New Issue
Closed
opened 2026-04-13 10:07:18 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 10:07:18 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7478
Author: @himself65
Created: 1/20/2026
Status: ✅ Merged
Merged: 1/20/2026
Merged by: @himself65

Base: canary ← Head: himself65/2026/01/19/error-response

📝 Commits (1)

  • f568292 fix: include Set-Cookie when APIError thrown in hooks

📊 Changes

4 files changed (+52 additions, -14 deletions)

View changed files

📝 packages/better-auth/src/api/to-auth-endpoints.test.ts (+14 -0)
📝 packages/better-auth/src/api/to-auth-endpoints.ts (+9 -2)
📝 pnpm-lock.yaml (+28 -11)
📝 pnpm-workspace.yaml (+1 -1)

📄 Description

Fixes: https://github.com/better-auth/better-auth/issues/7473
Fixes: https://github.com/better-auth/better-auth/issues/4983

Summary by cubic

Preserves Set-Cookie headers when after hooks throw APIError, so clients still receive cookie updates on error responses. Adds a test to ensure the header is included.

  • Bug Fixes

    • Propagate Set-Cookie from APIError via better-call’s header symbol.
    • Add test verifying Set-Cookie is returned when an after hook throws.

  • Dependencies

    • Upgrade better-call to 1.2.0 to support header propagation.

Written for commit f5682929b0. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7478 **Author:** [@himself65](https://github.com/himself65) **Created:** 1/20/2026 **Status:** ✅ Merged **Merged:** 1/20/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2026/01/19/error-response` --- ### 📝 Commits (1) - [`f568292`](https://github.com/better-auth/better-auth/commit/f5682929b0ad38306e78f5b16783eaebbf062ee2) fix: include `Set-Cookie` when APIError thrown in hooks ### 📊 Changes **4 files changed** (+52 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/api/to-auth-endpoints.test.ts` (+14 -0) 📝 `packages/better-auth/src/api/to-auth-endpoints.ts` (+9 -2) 📝 `pnpm-lock.yaml` (+28 -11) 📝 `pnpm-workspace.yaml` (+1 -1) </details> ### 📄 Description Fixes: https://github.com/better-auth/better-auth/issues/7473 Fixes: https://github.com/better-auth/better-auth/issues/4983 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Preserves Set-Cookie headers when after hooks throw APIError, so clients still receive cookie updates on error responses. Adds a test to ensure the header is included. - **Bug Fixes** - Propagate Set-Cookie from APIError via better-call’s header symbol. - Add test verifying Set-Cookie is returned when an after hook throws. - **Dependencies** - Upgrade better-call to 1.2.0 to support header propagation. <sup>Written for commit f5682929b0ad38306e78f5b16783eaebbf062ee2. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 10:07:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#15588
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?