github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7467] [MERGED] fix: /minimal includes unexpected deps #15579

New Issue
Closed
opened 2026-04-13 10:06:53 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 10:06:53 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7467
Author: @himself65
Created: 1/19/2026
Status: ✅ Merged
Merged: 1/19/2026
Merged by: @himself65

Base: canary ← Head: himself65/2026/01/18/adapter

📝 Commits (5)

📊 Changes

30 files changed (+131 additions, -31 deletions)

View changed files

📝 e2e/integration/solid-vinxi/src/lib/auth.ts (+1 -1)
📝 e2e/integration/vanilla-node/e2e/app.ts (+1 -1)
📝 e2e/integration/vanilla-node/e2e/postgres-js.spec.ts (+1 -1)
➕ e2e/smoke/test/esbuild.spec.ts (+35 -0)
📝 e2e/smoke/test/fixtures/bun-simple.ts (+1 -1)
📝 e2e/smoke/test/fixtures/deno-simple.ts (+1 -1)
➕ e2e/smoke/test/fixtures/esbuild/package.json (+10 -0)
➕ e2e/smoke/test/fixtures/esbuild/src/minimal.ts (+3 -0)
➕ e2e/smoke/test/fixtures/esbuild/src/server.ts (+1 -0)
➕ e2e/smoke/test/fixtures/esbuild/tsconfig.json (+11 -0)
➕ e2e/smoke/test/fixtures/vite/src/minimal.ts (+3 -0)
📝 e2e/smoke/test/fixtures/vite/vite.config.ts (+2 -1)
📝 e2e/smoke/test/ssr.ts (+1 -1)
📝 packages/better-auth/package.json (+24 -0)
📝 packages/better-auth/src/adapters/kysely-adapter/test/adapter.kysely.custom-schema-pg.test.ts (+1 -1)
📝 packages/better-auth/src/adapters/kysely-adapter/test/adapter.kysely.mssql.test.ts (+1 -1)
📝 packages/better-auth/src/adapters/kysely-adapter/test/adapter.kysely.mysql.test.ts (+1 -1)
📝 packages/better-auth/src/adapters/kysely-adapter/test/adapter.kysely.pg.test.ts (+1 -1)
📝 packages/better-auth/src/adapters/kysely-adapter/test/adapter.kysely.sqlite.test.ts (+1 -1)
📝 packages/better-auth/src/context/create-context.test.ts (+1 -1)

...and 10 more files

📄 Description

Fixes: https://github.com/better-auth/better-auth/issues/7438

Summary by cubic

Split DB adapter and migration utilities into subpath exports to stop better-auth/minimal from pulling unexpected dependencies. Adds Vite and esbuild smoke tests to ensure the minimal entry bundles cleanly.

  • Bug Fixes

    • better-auth/minimal no longer bundles DB adapters or migration helpers.
    • Added subpath exports: ./db/adapter, ./db/adapter/minimal, ./db/migration.
    • Updated internal, tests, and CLI to use new paths.
    • Added Vite and esbuild smoke tests (minimal.ts) and chunk naming for stable output.
    • Cleaned up imports (e.g., getAuthTables from @better-auth/core/db).

  • Migration

    • Update imports if you used DB helpers directly:
      • getAdapter -> better-auth/db/adapter
      • getBaseAdapter -> better-auth/db/adapter/minimal
      • getMigrations -> better-auth/db/migration

Written for commit 79890013e5. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7467 **Author:** [@himself65](https://github.com/himself65) **Created:** 1/19/2026 **Status:** ✅ Merged **Merged:** 1/19/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2026/01/18/adapter` --- ### 📝 Commits (5) - [`f6dcccc`](https://github.com/better-auth/better-auth/commit/f6dcccc907a384dc1dd82d818063921a23c323bb) fix: minimal includes unexpected deps - [`fdca78e`](https://github.com/better-auth/better-auth/commit/fdca78e091b321d9b01fde606fd1df162f3a9080) fix: minimal includes unexpected deps - [`7bf7b6e`](https://github.com/better-auth/better-auth/commit/7bf7b6e901ef7a2a86e9a3d8a4f0afac0e0e1164) fix: code - [`c093ccc`](https://github.com/better-auth/better-auth/commit/c093ccc9cadb72511299d0075d0c1102bc0394d0) fix: code - [`7989001`](https://github.com/better-auth/better-auth/commit/79890013e53d0c311c112cb12f16afc2d35a5a21) smoke test add ### 📊 Changes **30 files changed** (+131 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `e2e/integration/solid-vinxi/src/lib/auth.ts` (+1 -1) 📝 `e2e/integration/vanilla-node/e2e/app.ts` (+1 -1) 📝 `e2e/integration/vanilla-node/e2e/postgres-js.spec.ts` (+1 -1) ➕ `e2e/smoke/test/esbuild.spec.ts` (+35 -0) 📝 `e2e/smoke/test/fixtures/bun-simple.ts` (+1 -1) 📝 `e2e/smoke/test/fixtures/deno-simple.ts` (+1 -1) ➕ `e2e/smoke/test/fixtures/esbuild/package.json` (+10 -0) ➕ `e2e/smoke/test/fixtures/esbuild/src/minimal.ts` (+3 -0) ➕ `e2e/smoke/test/fixtures/esbuild/src/server.ts` (+1 -0) ➕ `e2e/smoke/test/fixtures/esbuild/tsconfig.json` (+11 -0) ➕ `e2e/smoke/test/fixtures/vite/src/minimal.ts` (+3 -0) 📝 `e2e/smoke/test/fixtures/vite/vite.config.ts` (+2 -1) 📝 `e2e/smoke/test/ssr.ts` (+1 -1) 📝 `packages/better-auth/package.json` (+24 -0) 📝 `packages/better-auth/src/adapters/kysely-adapter/test/adapter.kysely.custom-schema-pg.test.ts` (+1 -1) 📝 `packages/better-auth/src/adapters/kysely-adapter/test/adapter.kysely.mssql.test.ts` (+1 -1) 📝 `packages/better-auth/src/adapters/kysely-adapter/test/adapter.kysely.mysql.test.ts` (+1 -1) 📝 `packages/better-auth/src/adapters/kysely-adapter/test/adapter.kysely.pg.test.ts` (+1 -1) 📝 `packages/better-auth/src/adapters/kysely-adapter/test/adapter.kysely.sqlite.test.ts` (+1 -1) 📝 `packages/better-auth/src/context/create-context.test.ts` (+1 -1) _...and 10 more files_ </details> ### 📄 Description Fixes: https://github.com/better-auth/better-auth/issues/7438 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Split DB adapter and migration utilities into subpath exports to stop better-auth/minimal from pulling unexpected dependencies. Adds Vite and esbuild smoke tests to ensure the minimal entry bundles cleanly. - **Bug Fixes** - better-auth/minimal no longer bundles DB adapters or migration helpers. - Added subpath exports: ./db/adapter, ./db/adapter/minimal, ./db/migration. - Updated internal, tests, and CLI to use new paths. - Added Vite and esbuild smoke tests (minimal.ts) and chunk naming for stable output. - Cleaned up imports (e.g., getAuthTables from @better-auth/core/db). - **Migration** - Update imports if you used DB helpers directly: - getAdapter -> better-auth/db/adapter - getBaseAdapter -> better-auth/db/adapter/minimal - getMigrations -> better-auth/db/migration <sup>Written for commit 79890013e53d0c311c112cb12f16afc2d35a5a21. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 10:06:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#15579
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?