github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7446] [MERGED] fix: update TanStack imports to use server subpath #15565

New Issue
Closed
opened 2026-04-13 10:06:18 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 10:06:18 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7446
Author: @himself65
Created: 1/18/2026
Status: ✅ Merged
Merged: 1/18/2026
Merged by: @himself65

Base: canary ← Head: himself65/2026/01/17/start

📝 Commits (4)

  • e4e037e fix: update TanStack imports to use server subpath
  • 783fb01 fixup! fix: update TanStack imports to use server subpath
  • 357c6ae fixup! fix: update TanStack imports to use server subpath
  • b82bfa9 fixup! fix: update TanStack imports to use server subpath

📊 Changes

7 files changed (+534 additions, -169 deletions)

View changed files

➕ .postmortem/tanstack-start-server-core.md (+104 -0)
📝 knip.jsonc (+2 -2)
📝 packages/better-auth/package.json (+6 -6)
📝 packages/better-auth/src/integrations/tanstack-start-solid.ts (+1 -1)
📝 packages/better-auth/src/integrations/tanstack-start.ts (+1 -1)
📝 pnpm-lock.yaml (+420 -80)
➖ postmortem/tanstack-start-server-core.md (+0 -79)

📄 Description

Fixes: https://github.com/better-auth/better-auth/issues/7386

Summary by cubic

Updated TanStack imports to use the framework server subpaths to stop Vite pre-bundling crashes from virtual modules. Fixes GitHub issue #7386 and stabilizes cookie handling in TanStack Start integrations.

  • Bug Fixes

    • Use "@tanstack/react-start/server" and "@tanstack/solid-start/server" instead of "@tanstack/start-server-core".
    • Avoid Vite errors from "#tanstack-router-entry" virtual modules.

  • Dependencies

    • Change peer deps from "@tanstack/-start-server" to "@tanstack/-start" (v1.151.2).
    • Update lockfile to reflect new TanStack packages.

Written for commit b82bfa92e5. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7446 **Author:** [@himself65](https://github.com/himself65) **Created:** 1/18/2026 **Status:** ✅ Merged **Merged:** 1/18/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2026/01/17/start` --- ### 📝 Commits (4) - [`e4e037e`](https://github.com/better-auth/better-auth/commit/e4e037e671e5ca79e344fe26d31a00840fcfbca9) fix: update TanStack imports to use server subpath - [`783fb01`](https://github.com/better-auth/better-auth/commit/783fb01ff412180f73da3c043a8f5baf5a10149e) fixup! fix: update TanStack imports to use server subpath - [`357c6ae`](https://github.com/better-auth/better-auth/commit/357c6ae475373698b661fdd3962baef4d0a7bcea) fixup! fix: update TanStack imports to use server subpath - [`b82bfa9`](https://github.com/better-auth/better-auth/commit/b82bfa92e5b5c86d4e061960e297b87b6f07959d) fixup! fix: update TanStack imports to use server subpath ### 📊 Changes **7 files changed** (+534 additions, -169 deletions) <details> <summary>View changed files</summary> ➕ `.postmortem/tanstack-start-server-core.md` (+104 -0) 📝 `knip.jsonc` (+2 -2) 📝 `packages/better-auth/package.json` (+6 -6) 📝 `packages/better-auth/src/integrations/tanstack-start-solid.ts` (+1 -1) 📝 `packages/better-auth/src/integrations/tanstack-start.ts` (+1 -1) 📝 `pnpm-lock.yaml` (+420 -80) ➖ `postmortem/tanstack-start-server-core.md` (+0 -79) </details> ### 📄 Description Fixes: https://github.com/better-auth/better-auth/issues/7386 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Updated TanStack imports to use the framework server subpaths to stop Vite pre-bundling crashes from virtual modules. Fixes GitHub issue #7386 and stabilizes cookie handling in TanStack Start integrations. - **Bug Fixes** - Use "@tanstack/react-start/server" and "@tanstack/solid-start/server" instead of "@tanstack/start-server-core". - Avoid Vite errors from "#tanstack-router-entry" virtual modules. - **Dependencies** - Change peer deps from "@tanstack/*-start-server" to "@tanstack/*-start" (v1.151.2). - Update lockfile to reflect new TanStack packages. <sup>Written for commit b82bfa92e5b5c86d4e061960e297b87b6f07959d. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 10:06:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#15565
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?