github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6979] [MERGED] chore(sso): allow Buffer #15250

New Issue
Closed
opened 2026-04-13 09:54:59 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:54:59 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6979
Author: @himself65
Created: 12/24/2025
Status: ✅ Merged
Merged: 12/24/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/12/24/buffer

📝 Commits (4)

  • 1994d4a chore(sso): allow Buffer
  • 1166c9e chore: remove unused
  • 1d6d283 Merge branch 'canary' into himself65/2025/12/24/buffer
  • 263a5f7 chore: lock

📊 Changes

4 files changed (+16 additions, -20 deletions)

View changed files

📝 biome.json (+2 -1)
📝 packages/sso/package.json (+0 -1)
📝 packages/sso/src/routes/sso.ts (+6 -7)
📝 pnpm-lock.yaml (+8 -11)

📄 Description

After discussion, we only allow node.js environment for SSO plugin

Summary by cubic

Switch SSO SAML decoding to Node.js Buffer and restrict the SSO plugin to Node-only. This improves SAML validation and error logging consistency.

  • Refactors

    • Replace base64.decode + TextDecoder with Buffer.from(..., "base64").toString("utf-8") in callbackSSOSAML and acsEndpoint.
    • Update biome.json to exclude packages/sso/** to align tooling with Node-only support.

  • Dependencies

    • Remove @better-auth/utils from packages/sso since the base64 helper is no longer used.

Written for commit 263a5f7343. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6979 **Author:** [@himself65](https://github.com/himself65) **Created:** 12/24/2025 **Status:** ✅ Merged **Merged:** 12/24/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/12/24/buffer` --- ### 📝 Commits (4) - [`1994d4a`](https://github.com/better-auth/better-auth/commit/1994d4ac47bda593fc244e21557fb3035ec9cf04) chore(sso): allow `Buffer` - [`1166c9e`](https://github.com/better-auth/better-auth/commit/1166c9e2f9b23b7db1c6c8cde717c1e8ccf69362) chore: remove unused - [`1d6d283`](https://github.com/better-auth/better-auth/commit/1d6d283b3fd5d6d1f8200d9f28256430156e1deb) Merge branch 'canary' into himself65/2025/12/24/buffer - [`263a5f7`](https://github.com/better-auth/better-auth/commit/263a5f734368d2d613fcb398b4846d7269f62162) chore: lock ### 📊 Changes **4 files changed** (+16 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `biome.json` (+2 -1) 📝 `packages/sso/package.json` (+0 -1) 📝 `packages/sso/src/routes/sso.ts` (+6 -7) 📝 `pnpm-lock.yaml` (+8 -11) </details> ### 📄 Description After discussion, we only allow node.js environment for SSO plugin <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Switch SSO SAML decoding to Node.js Buffer and restrict the SSO plugin to Node-only. This improves SAML validation and error logging consistency. - **Refactors** - Replace base64.decode + TextDecoder with Buffer.from(..., "base64").toString("utf-8") in callbackSSOSAML and acsEndpoint. - Update biome.json to exclude packages/sso/** to align tooling with Node-only support. - **Dependencies** - Remove @better-auth/utils from packages/sso since the base64 helper is no longer used. <sup>Written for commit 263a5f734368d2d613fcb398b4846d7269f62162. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 09:54:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#15250
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?