github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6963] [MERGED] fix: correct accountLinking default to true #15241

New Issue
Closed
opened 2026-04-13 09:54:37 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:54:37 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6963
Author: @bytaesu
Created: 12/23/2025
Status: ✅ Merged
Merged: 12/24/2025
Merged by: @himself65

Base: canary ← Head: 2025-12-24/fix/account-linking-default-true

📝 Commits (3)

  • b516e2c fix(one-tap): correct accountLinking enabled default handling
  • 6103363 docs: accountLinking default is true
  • 4fd44a4 Merge branch 'canary' into 2025-12-24/fix/account-linking-default-true

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 docs/content/docs/reference/options.mdx (+1 -1)
📝 packages/better-auth/src/plugins/one-tap/index.ts (+2 -2)

📄 Description

Except for one place where the default was handled incorrectly, the internal logic had default as true. The docs has been updated accordingly.

Closes https://github.com/better-auth/better-auth/issues/6848

Summary by cubic

Corrected account linking default to true in the One Tap plugin and updated docs to match. Accounts will auto-link unless accountLinking.enabled is explicitly set to false.

  • Bug Fixes
    • Use enabled !== false to honor the true default in One Tap linking logic.
    • Add optional chaining when reading trustedProviders to avoid errors if accountLinking is undefined.

Written for commit 4fd44a4960. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6963 **Author:** [@bytaesu](https://github.com/bytaesu) **Created:** 12/23/2025 **Status:** ✅ Merged **Merged:** 12/24/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `2025-12-24/fix/account-linking-default-true` --- ### 📝 Commits (3) - [`b516e2c`](https://github.com/better-auth/better-auth/commit/b516e2c88c2dff095f2984a471e659767025a2b8) fix(one-tap): correct accountLinking enabled default handling - [`6103363`](https://github.com/better-auth/better-auth/commit/6103363fc8b0c6b1bc24a45e7298132270f08301) docs: accountLinking default is true - [`4fd44a4`](https://github.com/better-auth/better-auth/commit/4fd44a49607211f7ef64f3a2fafe2456147864f3) Merge branch 'canary' into 2025-12-24/fix/account-linking-default-true ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `docs/content/docs/reference/options.mdx` (+1 -1) 📝 `packages/better-auth/src/plugins/one-tap/index.ts` (+2 -2) </details> ### 📄 Description Except for one place where the default was handled incorrectly, the internal logic had default as true. The docs has been updated accordingly. Closes https://github.com/better-auth/better-auth/issues/6848 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Corrected account linking default to true in the One Tap plugin and updated docs to match. Accounts will auto-link unless accountLinking.enabled is explicitly set to false. - **Bug Fixes** - Use enabled !== false to honor the true default in One Tap linking logic. - Add optional chaining when reading trustedProviders to avoid errors if accountLinking is undefined. <sup>Written for commit 4fd44a49607211f7ef64f3a2fafe2456147864f3. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 09:54:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#15241
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?