github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6873] [MERGED] test: coverage with asResponse #15184

New Issue
Closed
opened 2026-04-13 09:52:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:52:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6873
Author: @himself65
Created: 12/19/2025
Status: ✅ Merged
Merged: 12/23/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/12/19/test

📝 Commits (3)

  • eba6c68 test: coverage with asResponse
  • 0dfd3d4 Update test/unit/oauth/index.spec.ts
  • fd303e4 Merge branch 'canary' into himself65/2025/12/19/test

📊 Changes

1 file changed (+36 additions, -2 deletions)

View changed files

📝 test/unit/oauth/index.spec.ts (+36 -2)

📄 Description

Closes: https://github.com/better-auth/better-auth/issues/6859

Summary by cubic

Expanded OAuth tests to cover signInSocial with asResponse. Confirms it returns a Response and checks logger behavior.

  • Verifies an error log when provider is missing (microsoft).
  • Verifies no error log for a valid provider (google).

Written for commit fd303e4887. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6873 **Author:** [@himself65](https://github.com/himself65) **Created:** 12/19/2025 **Status:** ✅ Merged **Merged:** 12/23/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/12/19/test` --- ### 📝 Commits (3) - [`eba6c68`](https://github.com/better-auth/better-auth/commit/eba6c683466a761e8831b366dc8363cebbe767c4) test: coverage with `asResponse` - [`0dfd3d4`](https://github.com/better-auth/better-auth/commit/0dfd3d4f012a62b3e0aee59672391e1d19fe51ee) Update test/unit/oauth/index.spec.ts - [`fd303e4`](https://github.com/better-auth/better-auth/commit/fd303e4887d49eb5f2582d19d99fa242b5c2667f) Merge branch 'canary' into himself65/2025/12/19/test ### 📊 Changes **1 file changed** (+36 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `test/unit/oauth/index.spec.ts` (+36 -2) </details> ### 📄 Description Closes: https://github.com/better-auth/better-auth/issues/6859 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Expanded OAuth tests to cover signInSocial with asResponse. Confirms it returns a Response and checks logger behavior. - Verifies an error log when provider is missing (microsoft). - Verifies no error log for a valid provider (google). <sup>Written for commit fd303e4887d49eb5f2582d19d99fa242b5c2667f. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 09:52:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#15184
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?