github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6867] fix: passkey - correct verification deletion when using useNumberId #15180

New Issue
Open
opened 2026-04-13 09:52:26 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:52:26 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6867
Author: @tbveloso
Created: 12/18/2025
Status: 🔄 Open

Base: main ← Head: canary

📝 Commits (1)

  • 95cc306 fix: passkey - correct verification deletion when using useNumberId

📊 Changes

1 file changed (+6 additions, -2 deletions)

View changed files

📝 packages/passkey/src/routes.ts (+6 -2)

📄 Description

Summary by cubic

Fixes incorrect cleanup of passkey verification challenges by deleting records by identifier, ensuring proper removal when useNumberId is enabled in both registration and authentication flows.

  • Bug Fixes
    • Replace internalAdapter.deleteVerificationValue with deleteVerificationByIdentifier(challengeId) in verifyPasskeyRegistration and verifyPasskeyAuthentication to prevent stale verification entries.

Written for commit 95cc3065d3. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6867 **Author:** [@tbveloso](https://github.com/tbveloso) **Created:** 12/18/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `canary` --- ### 📝 Commits (1) - [`95cc306`](https://github.com/better-auth/better-auth/commit/95cc3065d314037e4220f9572cf5f3651087f919) fix: passkey - correct verification deletion when using useNumberId ### 📊 Changes **1 file changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/passkey/src/routes.ts` (+6 -2) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Fixes incorrect cleanup of passkey verification challenges by deleting records by identifier, ensuring proper removal when useNumberId is enabled in both registration and authentication flows. - **Bug Fixes** - Replace internalAdapter.deleteVerificationValue with deleteVerificationByIdentifier(challengeId) in verifyPasskeyRegistration and verifyPasskeyAuthentication to prevent stale verification entries. <sup>Written for commit 95cc3065d314037e4220f9572cf5f3651087f919. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 09:52:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#15180
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?