github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6677] [CLOSED] feat(integrations): support both react and solid flavors of tanstack-start #15064

New Issue
Closed
opened 2026-04-13 09:48:28 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:48:28 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6677
Author: @asterikx
Created: 12/10/2025
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (3)

  • 6536bdb feat(integraions): support both react and solid flavors of
  • f4e733c chore: revert packageManager in package.json
  • 82d4f59 fix: style

📊 Changes

4 files changed (+9 additions, -345 deletions)

View changed files

📝 knip.jsonc (+0 -1)
📝 packages/better-auth/package.json (+2 -2)
📝 packages/better-auth/src/integrations/tanstack-start.ts (+1 -3)
📝 pnpm-lock.yaml (+6 -339)

📄 Description

Support both React and Solid flavors of Tanstack Start equally.

Previously, the following import led to build and/or runtime errors in projects using @tanstack/react-solid:

import { tanstackStartCookies } from "better-auth/tanstack-start"

since such projects do not depend on @tanstack/react-start.

This PR imports getCookie from @tanstack/start-server-core which is a peer direct dependency of both @tanstack/react-start and @tanstack/react-solid so that the import works in both cases.

Summary by cubic

Update TanStack Start integration to use @tanstack/start-server-core for cookie handling so it works with both React and Solid flavors. This prevents build/runtime errors in @tanstack/react-solid apps importing better-auth/tanstack-start.

  • Bug Fixes

    • Replaced cookie utilities import from @tanstack/react-start/server with @tanstack/start-server-core to support both flavors.

  • Dependencies

    • Changed peer dependency in packages/better-auth from @tanstack/react-start to @tanstack/start-server-core (optional).

Written for commit 82d4f59f72. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6677 **Author:** [@asterikx](https://github.com/asterikx) **Created:** 12/10/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (3) - [`6536bdb`](https://github.com/better-auth/better-auth/commit/6536bdb15029d7af73076f6a0d2d1f3de9266678) feat(integraions): support both react and solid flavors of - [`f4e733c`](https://github.com/better-auth/better-auth/commit/f4e733c426334812fe1dadff59cf6dd82eac4fd4) chore: revert packageManager in package.json - [`82d4f59`](https://github.com/better-auth/better-auth/commit/82d4f59f724de2b6ce86634a0eb97aed976a07b4) fix: style ### 📊 Changes **4 files changed** (+9 additions, -345 deletions) <details> <summary>View changed files</summary> 📝 `knip.jsonc` (+0 -1) 📝 `packages/better-auth/package.json` (+2 -2) 📝 `packages/better-auth/src/integrations/tanstack-start.ts` (+1 -3) 📝 `pnpm-lock.yaml` (+6 -339) </details> ### 📄 Description Support both React and Solid flavors of Tanstack Start equally. Previously, the following import led to build and/or runtime errors in projects using `@tanstack/react-solid`: ``` import { tanstackStartCookies } from "better-auth/tanstack-start" ``` since such projects do not depend on `@tanstack/react-start`. This PR imports `getCookie` from `@tanstack/start-server-core` which is a peer direct dependency of both `@tanstack/react-start` and `@tanstack/react-solid` so that the import works in both cases. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Update TanStack Start integration to use @tanstack/start-server-core for cookie handling so it works with both React and Solid flavors. This prevents build/runtime errors in @tanstack/react-solid apps importing better-auth/tanstack-start. - **Bug Fixes** - Replaced cookie utilities import from @tanstack/react-start/server with @tanstack/start-server-core to support both flavors. - **Dependencies** - Changed peer dependency in packages/better-auth from @tanstack/react-start to @tanstack/start-server-core (optional). <sup>Written for commit 82d4f59f724de2b6ce86634a0eb97aed976a07b4. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 09:48:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#15064
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?