github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6477] [MERGED] refactor: move adapter-factory to core #14941

New Issue
Closed
opened 2026-04-13 09:43:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:43:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6477
Author: @himself65
Created: 12/2/2025
Status: ✅ Merged
Merged: 12/3/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/12/02/refactor

📝 Commits (6)

📊 Changes

48 files changed (+102 additions, -109 deletions)

View changed files

📝 packages/better-auth/src/adapters/create-test-suite.ts (+7 -7)
📝 packages/better-auth/src/adapters/drizzle-adapter/drizzle-adapter.ts (+3 -5)
📝 packages/better-auth/src/adapters/index.ts (+2 -2)
📝 packages/better-auth/src/adapters/kysely-adapter/kysely-adapter.ts (+3 -5)
📝 packages/better-auth/src/adapters/memory-adapter/memory-adapter.ts (+1 -1)
📝 packages/better-auth/src/adapters/mongodb-adapter/mongodb-adapter.ts (+3 -5)
📝 packages/better-auth/src/adapters/prisma-adapter/prisma-adapter.ts (+3 -5)
📝 packages/better-auth/src/adapters/test-adapter.ts (+1 -2)
📝 packages/better-auth/src/adapters/tests/__snapshots__/adapter-factory.test.ts.snap (+0 -0)
📝 packages/better-auth/src/adapters/tests/adapter-factory.test.ts (+7 -6)
📝 packages/better-auth/src/api/rate-limiter/index.ts (+1 -1)
📝 packages/better-auth/src/api/routes/callback.ts (+1 -1)
📝 packages/better-auth/src/api/routes/session.ts (+1 -1)
📝 packages/better-auth/src/context/create-context.ts (+1 -1)
📝 packages/better-auth/src/cookies/index.ts (+1 -1)
📝 packages/better-auth/src/cookies/session-store.ts (+1 -1)
📝 packages/better-auth/src/db/adapter-base.ts (+1 -1)
📝 packages/better-auth/src/db/get-migration.ts (+5 -3)
📝 packages/better-auth/src/db/index.ts (+0 -1)
📝 packages/better-auth/src/db/internal-adapter.test.ts (+1 -1)

...and 28 more files

📄 Description

Summary by cubic

Moved the DB adapter factory and related helpers into core to unify adapter creation and simplify imports across packages. No behavior changes; this is a path and type refactor.

  • Refactors

    • Moved adapter factory, helpers, and types to core (packages/core/src/db/adapter) and exported via @better-auth/core/db/adapter.
    • Centralized getAuthTables in core and exported via @better-auth/core/db.
    • Exposed generateId and safeJSONParse from @better-auth/core/utils; removed local JSON/ID utils and updated references.
    • Exported deepmerge from @better-auth/core/db/adapter and updated tests to use it; removed obsolete snapshot.
    • Kept type back-compat (e.g., BetterAuthDbSchema alias); added Prettify in core.

  • Migration

    • Import createAdapterFactory and adapter helpers from @better-auth/core/db/adapter.
    • Import getAuthTables from @better-auth/core/db.
    • Import generateId and safeJSONParse from @better-auth/core/utils.

Written for commit b26a9777d0. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6477 **Author:** [@himself65](https://github.com/himself65) **Created:** 12/2/2025 **Status:** ✅ Merged **Merged:** 12/3/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/12/02/refactor` --- ### 📝 Commits (6) - [`c668592`](https://github.com/better-auth/better-auth/commit/c668592b7950fe6f63c0c302d6f3227e0183ed25) refactor: move adapter-factory to core - [`8c94af5`](https://github.com/better-auth/better-auth/commit/8c94af5af802b1c649076cdcbf1c030981f2e712) fix: import path - [`5621435`](https://github.com/better-auth/better-auth/commit/5621435f4308c66b8ff7df4f7ad26f89b86b0292) fix: type check - [`7cdb3d1`](https://github.com/better-auth/better-auth/commit/7cdb3d1b5357ef49013b987b89ca037799a0f5e5) revert - [`b248080`](https://github.com/better-auth/better-auth/commit/b2480800fd0d76ce8599a8ff9c7f1a9669a1ce5b) Update packages/better-auth/src/db/index.ts - [`b26a977`](https://github.com/better-auth/better-auth/commit/b26a9777d03b2cde3b07213247263a49f0751a67) fixup! ### 📊 Changes **48 files changed** (+102 additions, -109 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/adapters/create-test-suite.ts` (+7 -7) 📝 `packages/better-auth/src/adapters/drizzle-adapter/drizzle-adapter.ts` (+3 -5) 📝 `packages/better-auth/src/adapters/index.ts` (+2 -2) 📝 `packages/better-auth/src/adapters/kysely-adapter/kysely-adapter.ts` (+3 -5) 📝 `packages/better-auth/src/adapters/memory-adapter/memory-adapter.ts` (+1 -1) 📝 `packages/better-auth/src/adapters/mongodb-adapter/mongodb-adapter.ts` (+3 -5) 📝 `packages/better-auth/src/adapters/prisma-adapter/prisma-adapter.ts` (+3 -5) 📝 `packages/better-auth/src/adapters/test-adapter.ts` (+1 -2) 📝 `packages/better-auth/src/adapters/tests/__snapshots__/adapter-factory.test.ts.snap` (+0 -0) 📝 `packages/better-auth/src/adapters/tests/adapter-factory.test.ts` (+7 -6) 📝 `packages/better-auth/src/api/rate-limiter/index.ts` (+1 -1) 📝 `packages/better-auth/src/api/routes/callback.ts` (+1 -1) 📝 `packages/better-auth/src/api/routes/session.ts` (+1 -1) 📝 `packages/better-auth/src/context/create-context.ts` (+1 -1) 📝 `packages/better-auth/src/cookies/index.ts` (+1 -1) 📝 `packages/better-auth/src/cookies/session-store.ts` (+1 -1) 📝 `packages/better-auth/src/db/adapter-base.ts` (+1 -1) 📝 `packages/better-auth/src/db/get-migration.ts` (+5 -3) 📝 `packages/better-auth/src/db/index.ts` (+0 -1) 📝 `packages/better-auth/src/db/internal-adapter.test.ts` (+1 -1) _...and 28 more files_ </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Moved the DB adapter factory and related helpers into core to unify adapter creation and simplify imports across packages. No behavior changes; this is a path and type refactor. - **Refactors** - Moved adapter factory, helpers, and types to core (packages/core/src/db/adapter) and exported via @better-auth/core/db/adapter. - Centralized getAuthTables in core and exported via @better-auth/core/db. - Exposed generateId and safeJSONParse from @better-auth/core/utils; removed local JSON/ID utils and updated references. - Exported deepmerge from @better-auth/core/db/adapter and updated tests to use it; removed obsolete snapshot. - Kept type back-compat (e.g., BetterAuthDbSchema alias); added Prettify in core. - **Migration** - Import createAdapterFactory and adapter helpers from @better-auth/core/db/adapter. - Import getAuthTables from @better-auth/core/db. - Import generateId and safeJSONParse from @better-auth/core/utils. <sup>Written for commit b26a9777d03b2cde3b07213247263a49f0751a67. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 09:43:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#14941
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?