github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6434] [MERGED] docs: standardize warning formatting for email sending to prevent timing attacks #14913

New Issue
Closed
opened 2026-04-13 09:41:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:41:58 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6434
Author: @Bekacru
Created: 11/30/2025
Status: ✅ Merged
Merged: 11/30/2025
Merged by: @Bekacru

Base: canary ← Head: docs/email-awaits

📝 Commits (7)

  • cde4873 docs: add warnings about awaiting emails
  • ce6c59b docs: standardize warning formatting for email sending to prevent timing attacks
  • 5778774 Merge remote-tracking branch 'origin/canary' into docs/email-awaits
  • 06072f0 fix
  • 08cd702 fix
  • de74f0b fix
  • d86a505 fix

📊 Changes

3 files changed (+7 additions, -7 deletions)

View changed files

📝 docs/content/docs/authentication/email-password.mdx (+2 -2)
📝 docs/content/docs/concepts/email.mdx (+2 -2)
📝 docs/content/docs/concepts/users-accounts.mdx (+3 -3)

📄 Description

Summary by cubic

Standardized email-sending docs to avoid awaiting email operations, reducing timing attack risk. Updated examples (email verification, password reset, change email) to use void sendEmail or non-awaited sendEmail and added warn callouts recommending waitUntil on serverless platforms.

Written for commit d86a505ab6. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6434 **Author:** [@Bekacru](https://github.com/Bekacru) **Created:** 11/30/2025 **Status:** ✅ Merged **Merged:** 11/30/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `docs/email-awaits` --- ### 📝 Commits (7) - [`cde4873`](https://github.com/better-auth/better-auth/commit/cde4873223d87e69ba2ef201a7649b3da4dd2c6e) docs: add warnings about awaiting emails - [`ce6c59b`](https://github.com/better-auth/better-auth/commit/ce6c59bb62dd3645a4bdab5db6b940aed20881bd) docs: standardize warning formatting for email sending to prevent timing attacks - [`5778774`](https://github.com/better-auth/better-auth/commit/57787746a9a07be969cf5822d14f081c37fedf3e) Merge remote-tracking branch 'origin/canary' into docs/email-awaits - [`06072f0`](https://github.com/better-auth/better-auth/commit/06072f08674a9391b64d526be53c5f0a928e98ca) fix - [`08cd702`](https://github.com/better-auth/better-auth/commit/08cd7020ade331db6c4e1a1443e5841f592d41bd) fix - [`de74f0b`](https://github.com/better-auth/better-auth/commit/de74f0b6a65c92d7635fd4eb4a48b154fae38563) fix - [`d86a505`](https://github.com/better-auth/better-auth/commit/d86a505ab6e6b885de9e60108296ddc3324a8bca) fix ### 📊 Changes **3 files changed** (+7 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `docs/content/docs/authentication/email-password.mdx` (+2 -2) 📝 `docs/content/docs/concepts/email.mdx` (+2 -2) 📝 `docs/content/docs/concepts/users-accounts.mdx` (+3 -3) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Standardized email-sending docs to avoid awaiting email operations, reducing timing attack risk. Updated examples (email verification, password reset, change email) to use void sendEmail or non-awaited sendEmail and added warn callouts recommending waitUntil on serverless platforms. <sup>Written for commit d86a505ab6e6b885de9e60108296ddc3324a8bca. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 09:41:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#14913
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?