github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 08:01:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6428] [CLOSED] fix(integrations): tanstack start integration is now framework-agnostic #14907

New Issue
Closed
opened 2026-04-13 09:41:48 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:41:48 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6428
Author: @laptou
Created: 11/30/2025
Status: ❌ Closed

Base: canary ← Head: tanstack-start-framework-agnostic

📝 Commits (3)

  • f6a5a0a fix(integrations): tanstack start integration is now framework-agnostic
  • 65127de biome check
  • 5b598f8 put the next version back

📊 Changes

4 files changed (+38 additions, -356 deletions)

View changed files

📝 packages/better-auth/package.json (+1 -1)
📝 packages/better-auth/src/integrations/tanstack-start.ts (+1 -3)
📝 packages/better-auth/tsdown.config.ts (+1 -1)
📝 pnpm-lock.yaml (+35 -351)

📄 Description

TanStack Start can be used with React or with Solid. I am using it with Solid, which means I did not have React installed in my project. The tanstackStartCookies() plugin introduced an implicit dependency on React, which broke my build.

However, it's possible to implement the same functionality using the TanStack Start "core" package instead of their React-specific package. This PR updates the code to use the core package so that it doesn't break for TanStack Start Solid users.

Summary by cubic

Make the TanStack Start integration framework-agnostic. Switch to @tanstack/start-server-core to remove the implicit React dependency and fix builds for Solid users.

  • Bug Fixes

    • Replace server import with @tanstack/start-server-core.
    • Update peerDependency and tsdown externals to @tanstack/start-server-core.
    • Refresh lockfile to drop React-specific Start packages.
    • Adjust Next peer range to ^14 || ^15 || ^16.

  • Migration

    • Ensure @tanstack/start-server-core ^1.0.0 is available in projects using TanStack Start.

Written for commit 5b598f89b0. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6428 **Author:** [@laptou](https://github.com/laptou) **Created:** 11/30/2025 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `tanstack-start-framework-agnostic` --- ### 📝 Commits (3) - [`f6a5a0a`](https://github.com/better-auth/better-auth/commit/f6a5a0ac944c4018aede57ba73147df538f2b9ac) fix(integrations): tanstack start integration is now framework-agnostic - [`65127de`](https://github.com/better-auth/better-auth/commit/65127de9f7bd0eaa0f5a1614b2e3a64ec4e362bf) biome check - [`5b598f8`](https://github.com/better-auth/better-auth/commit/5b598f89b071f95246a77d437aa9f5755ca229a2) put the next version back ### 📊 Changes **4 files changed** (+38 additions, -356 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/package.json` (+1 -1) 📝 `packages/better-auth/src/integrations/tanstack-start.ts` (+1 -3) 📝 `packages/better-auth/tsdown.config.ts` (+1 -1) 📝 `pnpm-lock.yaml` (+35 -351) </details> ### 📄 Description TanStack Start can be used with React or with Solid. I am using it with Solid, which means I did not have React installed in my project. The `tanstackStartCookies()` plugin introduced an implicit dependency on React, which broke my build. However, it's possible to implement the same functionality using the TanStack Start "core" package instead of their React-specific package. This PR updates the code to use the core package so that it doesn't break for TanStack Start Solid users. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Make the TanStack Start integration framework-agnostic. Switch to @tanstack/start-server-core to remove the implicit React dependency and fix builds for Solid users. - **Bug Fixes** - Replace server import with @tanstack/start-server-core. - Update peerDependency and tsdown externals to @tanstack/start-server-core. - Refresh lockfile to drop React-specific Start packages. - Adjust Next peer range to ^14 || ^15 || ^16. - **Migration** - Ensure @tanstack/start-server-core ^1.0.0 is available in projects using TanStack Start. <sup>Written for commit 5b598f89b071f95246a77d437aa9f5755ca229a2. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 09:41:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#14907
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?