github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 08:01:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6199] [MERGED] fix(passkey): change generate-authenticate-options from POST to GET #14762

New Issue
Closed
opened 2026-04-13 09:37:37 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:37:37 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6199
Author: @mburumaxwell
Created: 11/22/2025
Status: ✅ Merged
Merged: 11/22/2025
Merged by: @Bekacru

Base: canary ← Head: fix/passkey-generate-authenticate-options-method

📝 Commits (1)

  • 3acedfd fix(passkey): change generate-authenticate-options from POST to GET

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 packages/passkey/src/client.ts (+1 -1)
📝 packages/passkey/src/index.ts (+1 -1)

📄 Description

Fixes #6197

Changes

  • Changed /passkey/generate-authenticate-options from POST to GET method
  • Updated both server endpoint definition and client implementation

Reason

The better-call upgrade (v1.0.19 → v1.1.0) introduced Content-Type validation for POST requests. Since this endpoint doesn't accept a body, using GET is semantically correct and matches the pattern used by /passkey/generate-register-options.

Summary by cubic

Switch /passkey/generate-authenticate-options from POST to GET to fix Content-Type validation errors in better-call v1.1.0 when no body is sent. Updates both the server endpoint and client call, and matches /passkey/generate-register-options.

Written for commit 3acedfd316. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6199 **Author:** [@mburumaxwell](https://github.com/mburumaxwell) **Created:** 11/22/2025 **Status:** ✅ Merged **Merged:** 11/22/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `fix/passkey-generate-authenticate-options-method` --- ### 📝 Commits (1) - [`3acedfd`](https://github.com/better-auth/better-auth/commit/3acedfd316fd9cd015c6b6c7ed9297c64563e94d) fix(passkey): change `generate-authenticate-options` from POST to GET ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/passkey/src/client.ts` (+1 -1) 📝 `packages/passkey/src/index.ts` (+1 -1) </details> ### 📄 Description Fixes #6197 ## Changes - Changed `/passkey/generate-authenticate-options` from POST to GET method - Updated both server endpoint definition and client implementation ## Reason The `better-call` upgrade (v1.0.19 → v1.1.0) introduced `Content-Type` validation for POST requests. Since this endpoint doesn't accept a body, using GET is semantically correct and matches the pattern used by `/passkey/generate-register-options`. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Switch /passkey/generate-authenticate-options from POST to GET to fix Content-Type validation errors in better-call v1.1.0 when no body is sent. Updates both the server endpoint and client call, and matches /passkey/generate-register-options. <sup>Written for commit 3acedfd316fd9cd015c6b6c7ed9297c64563e94d. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 09:37:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#14762
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?