github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6176] [MERGED] fix(two-factor): use constant time equal for otp comparison #14749

New Issue
Closed
opened 2026-04-13 09:37:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:37:07 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6176
Author: @Bekacru
Created: 11/21/2025
Status: ✅ Merged
Merged: 11/21/2025
Merged by: @Bekacru

Base: canary ← Head: fix/2fa

📝 Commits (2)

  • accfc40 fix(two-factor): use constant time equal for otp comparison
  • 35ae0e8 Merge branch 'canary' into fix/2fa

📊 Changes

2 files changed (+16 additions, -2 deletions)

View changed files

📝 packages/better-auth/src/plugins/two-factor/backup-codes/index.ts (+10 -1)
📝 packages/better-auth/src/plugins/two-factor/otp/index.ts (+6 -1)

📄 Description

Summary by cubic

Strengthens 2FA security by using constant-time OTP comparison and making backup code redemption atomic. Prevents timing attacks and avoids double-use of backup codes under concurrent requests.

  • Bug Fixes
    • Use constantTimeEqual for OTP verification instead of direct string comparison.
    • Make backup code updates conditional on the current backupCodes and throw CONFLICT if no rows update, preventing race conditions.

Written for commit 35ae0e8dcd. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6176 **Author:** [@Bekacru](https://github.com/Bekacru) **Created:** 11/21/2025 **Status:** ✅ Merged **Merged:** 11/21/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `fix/2fa` --- ### 📝 Commits (2) - [`accfc40`](https://github.com/better-auth/better-auth/commit/accfc40440bebabea3071a7443442aff4915664b) fix(two-factor): use constant time equal for otp comparison - [`35ae0e8`](https://github.com/better-auth/better-auth/commit/35ae0e8dcd84c1b242eee28b5f3caa942817337c) Merge branch 'canary' into fix/2fa ### 📊 Changes **2 files changed** (+16 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/two-factor/backup-codes/index.ts` (+10 -1) 📝 `packages/better-auth/src/plugins/two-factor/otp/index.ts` (+6 -1) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Strengthens 2FA security by using constant-time OTP comparison and making backup code redemption atomic. Prevents timing attacks and avoids double-use of backup codes under concurrent requests. - **Bug Fixes** - Use constantTimeEqual for OTP verification instead of direct string comparison. - Make backup code updates conditional on the current backupCodes and throw CONFLICT if no rows update, preventing race conditions. <sup>Written for commit 35ae0e8dcd84c1b242eee28b5f3caa942817337c. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 09:37:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#14749
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?