github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5985] chore(fix): support native UUID generation #14609

New Issue
Closed
opened 2026-04-13 09:32:29 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:32:29 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/better-auth/better-auth/pull/5985

State: closed
Merged: Yes

follow up for #5823 - current logic was still relying on JS

can be easily tested with:

alter table "user" alter column id set default '00000000-0000-0000-0000-000000000000'::uuid;

import { Pool } from 'pg';
import { betterAuth } from './index.mjs';
import { getMigrations } from './db/index.mjs';

export async function runMigrations(auth) {
  try {
    const migration = await getMigrations(auth.options);
    console.log(`Running migrations`);
    await migration.runMigrations();
    console.log('Migrations run successfully');
  } catch (error) {
    console.error(error);
    throw error;
  }
}

const connectionString = '...'; // put conn str here

export const a = betterAuth({
    database: new Pool({
      connectionString,
    }),
    emailAndPassword: {
        enabled: true,
    },
    advanced: {
      database: {
        generateId: "uuid",
      },
    }
});

await runMigrations(a);
await a.api.signUpEmail({ body: { email: "test2@test.com", password: "2test123456", name: "test user2" } });

Summary by cubic

Fix the UUID generation logic to defer to the database when native UUIDs are supported. We now only generate UUIDs in JS when the database does not support them (config.supportsUUIDs is false).

Written for commit df688f58d8. Summary will update automatically on new commits.

**Original Pull Request:** https://github.com/better-auth/better-auth/pull/5985 **State:** closed **Merged:** Yes --- follow up for #5823 - current logic was still relying on JS can be easily tested with: ```sql alter table "user" alter column id set default '00000000-0000-0000-0000-000000000000'::uuid; ``` ```js import { Pool } from 'pg'; import { betterAuth } from './index.mjs'; import { getMigrations } from './db/index.mjs'; export async function runMigrations(auth) { try { const migration = await getMigrations(auth.options); console.log(`Running migrations`); await migration.runMigrations(); console.log('Migrations run successfully'); } catch (error) { console.error(error); throw error; } } const connectionString = '...'; // put conn str here export const a = betterAuth({ database: new Pool({ connectionString, }), emailAndPassword: { enabled: true, }, advanced: { database: { generateId: "uuid", }, } }); await runMigrations(a); await a.api.signUpEmail({ body: { email: "test2@test.com", password: "2test123456", name: "test user2" } }); ``` <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fix the UUID generation logic to defer to the database when native UUIDs are supported. We now only generate UUIDs in JS when the database does not support them (config.supportsUUIDs is false). <sup>Written for commit df688f58d80f0a84dc0391eb4b87d3f1110e4774. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. -->
GiteaMirror added the pull-request label 2026-04-13 09:32:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#14609
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?