github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5914] refactor: initFn for defineRequestState #14564

New Issue
Closed
opened 2026-04-13 09:31:48 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:31:48 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/better-auth/better-auth/pull/5914

State: closed
Merged: Yes

Summary by cubic

Refactored request-scoped state to use an init function with automatic defaults, simplifying the API and fixing OIDC login prompt handling without leaking state between requests.

  • Refactors

    • Replaced defineRequestState(schema) with defineRequestState(initFn); get() auto-initializes.
    • Store keys are now unique ref objects (exposed via ref).
    • Removed schema-based validation and Zod usage.
    • OAuth state defaults to null; prompt set defaults to an empty Set.
    • OIDC login prompt flow now uses request state (get/setPromptHandled) instead of ctx.context flags.

  • Migration

    • Replace defineRequestState(schema) with defineRequestState(() => initialValue).
    • Perform your own validation if needed (schema validation removed).
    • Update getOAuthState consumers to handle null results.
    • Use getPromptHandled/setPromptHandled instead of ctx.context.oidcLoginPromptHandled.

Written for commit 5627397147. Summary will update automatically on new commits.

**Original Pull Request:** https://github.com/better-auth/better-auth/pull/5914 **State:** closed **Merged:** Yes --- <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Refactored request-scoped state to use an init function with automatic defaults, simplifying the API and fixing OIDC login prompt handling without leaking state between requests. - **Refactors** - Replaced defineRequestState(schema) with defineRequestState(initFn); get() auto-initializes. - Store keys are now unique ref objects (exposed via ref). - Removed schema-based validation and Zod usage. - OAuth state defaults to null; prompt set defaults to an empty Set. - OIDC login prompt flow now uses request state (get/setPromptHandled) instead of ctx.context flags. - **Migration** - Replace defineRequestState(schema) with defineRequestState(() => initialValue). - Perform your own validation if needed (schema validation removed). - Update getOAuthState consumers to handle null results. - Use getPromptHandled/setPromptHandled instead of ctx.context.oidcLoginPromptHandled. <sup>Written for commit 56273971477794b5e8a4d66e27b0d21bb8b7cbd7. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. -->
GiteaMirror added the pull-request label 2026-04-13 09:31:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#14564
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?