github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5820] chore: use const tokenEndpoint declarations in social providers #14497

New Issue
Closed
opened 2026-04-13 09:30:22 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:30:22 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/better-auth/better-auth/pull/5820

State: closed
Merged: Yes

Noticed that in some social-providers, we reuse the same const tokenEndpoint declarations while in others we don't. This PR aims to remove that redundancy wherever applicable i.e. where validateAuthorizationCode and refreshAccessToken use the same tokenEndpoint.

Summary by cubic

Consolidated tokenEndpoint declarations in social providers by defining a single const per provider when both authorization and refresh use the same endpoint. This removes duplication and keeps endpoints consistent with no behavior changes.

  • Refactors
    • Replaced inline tokenEndpoint strings with a const in: Apple, Atlassian, Discord, Figma, GitHub, Hugging Face, Kakao, Naver, Polar, Roblox, Slack, Spotify, TikTok, Twitch, Twitter (X), VK.
    • Re-synced with latest canary; cleanup only, no API or functional changes.

Written for commit d0e693dab0. Summary will update on new commits.

**Original Pull Request:** https://github.com/better-auth/better-auth/pull/5820 **State:** closed **Merged:** Yes --- Noticed that in some social-providers, we reuse the same `const tokenEndpoint` declarations while in others we don't. This PR aims to remove that redundancy wherever applicable i.e. where `validateAuthorizationCode` and `refreshAccessToken` use the same `tokenEndpoint`. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Consolidated tokenEndpoint declarations in social providers by defining a single const per provider when both authorization and refresh use the same endpoint. This removes duplication and keeps endpoints consistent with no behavior changes. - **Refactors** - Replaced inline tokenEndpoint strings with a const in: Apple, Atlassian, Discord, Figma, GitHub, Hugging Face, Kakao, Naver, Polar, Roblox, Slack, Spotify, TikTok, Twitch, Twitter (X), VK. - Re-synced with latest canary; cleanup only, no API or functional changes. <sup>Written for commit d0e693dab07968fb7054d56be11d5345d7b4f10c. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. -->
GiteaMirror added the pull-request label 2026-04-13 09:30:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#14497
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?