github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 08:01:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5792] fix(two-factor): avoid GET endpoints with body #14473

New Issue
Closed
opened 2026-04-13 09:29:34 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:29:34 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/better-auth/better-auth/pull/5792

State: closed
Merged: Yes

What is changing?
With the upcoming better-call@1.0.26, GET endpoints will no longer allow a body to be specified, and instead all requests will be rejected.

To avoid issues with the change in behavior, I am updating all core endpoints to avoid this scenario. Right now, it impacts:

  • GET /two-factor/view-backup-codes -> POST /two-factor/view-backup-codes

Summary by cubic

Switch the two-factor backup codes endpoint from GET to POST to comply with better-call@1.0.26, which rejects GET requests with bodies. Updated the server endpoint and docs; behavior remains the same.

  • Migration

    • Call POST /two-factor/view-backup-codes instead of GET.
    • Request body and server-only access stay the same.

  • Dependencies

    • Bump better-call to 1.0.26.

Written for commit 3c78eb05b3. Summary will update automatically on new commits.

**Original Pull Request:** https://github.com/better-auth/better-auth/pull/5792 **State:** closed **Merged:** Yes --- **What is changing?** With the upcoming `better-call@1.0.26`, GET endpoints will [no longer allow](https://github.com/Bekacru/better-call/pull/64) a body to be specified, and instead all requests will be rejected. To avoid issues with the change in behavior, I am updating all core endpoints to avoid this scenario. Right now, it impacts: - GET `/two-factor/view-backup-codes` -> POST `/two-factor/view-backup-codes` <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Switch the two-factor backup codes endpoint from GET to POST to comply with better-call@1.0.26, which rejects GET requests with bodies. Updated the server endpoint and docs; behavior remains the same. - **Migration** - Call POST /two-factor/view-backup-codes instead of GET. - Request body and server-only access stay the same. - **Dependencies** - Bump better-call to 1.0.26. <sup>Written for commit 3c78eb05b3f09875bfbb0f088462ff52e67e29ee. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. -->
GiteaMirror added the pull-request label 2026-04-13 09:29:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#14473
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?