github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5701] fix: type mismatch for 'banned' on UserWithRole #14412

New Issue
Closed
opened 2026-04-13 09:27:42 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:27:42 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/better-auth/better-auth/pull/5701

State: closed
Merged: Yes

Resolves: #4830

Description

This PR fixes a TypeScript type mismatch between the admin plugin's UserWithRole type and the client-side inferred type authClient.$Infer.Session.user.

The Problem

The UserWithRole interface in packages/better-auth/src/plugins/admin/types.ts incorrectly defined the banned property as optional:
banned?: (boolean | null) | undefined;

This conflicts with the client-side type inference, which correctly expects the field to always be present.

The Fix

This is a pure type-definition fix. The database adapters (like the Drizzle adapter) use db.select() (which is SELECT *), guaranteeing the banned field will always be returned as true, false, or null - but never undefined.

This PR corrects the type definition in types.ts to banned: boolean | null; to match the actual data returned by the adapter, resolving the type error. No runtime changes are necessary.

Summary by cubic

Make UserWithRole.banned a required boolean | null to match the client session user type and prevent TypeScript errors in the admin plugin. No runtime changes; this aligns with DB adapters that always return the field.

Written for commit b687fcd341. Summary will update automatically on new commits.

**Original Pull Request:** https://github.com/better-auth/better-auth/pull/5701 **State:** closed **Merged:** Yes --- **Resolves: #4830** ### Description This PR fixes a TypeScript type mismatch between the `admin` plugin's `UserWithRole` type and the client-side inferred type `authClient.$Infer.Session.user`. ### The Problem The `UserWithRole` interface in `packages/better-auth/src/plugins/admin/types.ts` incorrectly defined the `banned` property as optional: `banned?: (boolean | null) | undefined;` This conflicts with the client-side type inference, which correctly expects the field to always be present. ### The Fix This is a pure type-definition fix. The database adapters (like the Drizzle adapter) use `db.select()` (which is `SELECT *`), guaranteeing the `banned` field will always be returned as `true`, `false`, or `null` - but **never** `undefined`. This PR corrects the type definition in `types.ts` to `banned: boolean | null;` to match the actual data returned by the adapter, resolving the type error. No runtime changes are necessary. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Make UserWithRole.banned a required boolean | null to match the client session user type and prevent TypeScript errors in the admin plugin. No runtime changes; this aligns with DB adapters that always return the field. <sup>Written for commit b687fcd341a8d0669d6412f3e98392ca1bc97566. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. -->
GiteaMirror added the pull-request label 2026-04-13 09:27:42 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#14412
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?