github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5661] fix(cli): use 64 bit ints for numeric IDs for mysql/mssql #14394

New Issue
Closed
opened 2026-04-13 09:27:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:27:14 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/better-auth/better-auth/pull/5661

State: closed
Merged: No

closes https://github.com/better-auth/better-auth/issues/5657

Should generate 64bit for ids with useNumberId. We don't do this for mysql & mssql on kysely, Prisma & Drizzle. This PR resolves such for the CLI generator & handles IDs as BigInt in the adapter factory.

Summary by cubic

Switch numeric IDs to 64-bit (BIGINT) for MySQL and MSSQL when useNumberId is enabled, and handle IDs as BigInt throughout the adapter. This prevents truncation and keeps the CLI generator and runtime consistent.

  • Bug Fixes

    • Generate BIGINT columns for numeric IDs in MySQL/MSSQL migrations.
    • Convert ID values to BigInt in the adapter factory for reads/writes.
    • Allow BigInt and BigInt[] in query Where values.

  • Migration

    • If you previously created INTEGER ID columns on MySQL/MSSQL with useNumberId, alter them to BIGINT.
    • Update application code to use BigInt for IDs (not Number), including query filters and payloads.
**Original Pull Request:** https://github.com/better-auth/better-auth/pull/5661 **State:** closed **Merged:** No --- closes https://github.com/better-auth/better-auth/issues/5657 Should generate 64bit for ids with `useNumberId`. We don't do this for mysql & mssql on kysely, Prisma & Drizzle. This PR resolves such for the CLI generator & handles IDs as `BigInt` in the adapter factory. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Switch numeric IDs to 64-bit (BIGINT) for MySQL and MSSQL when useNumberId is enabled, and handle IDs as BigInt throughout the adapter. This prevents truncation and keeps the CLI generator and runtime consistent. - **Bug Fixes** - Generate BIGINT columns for numeric IDs in MySQL/MSSQL migrations. - Convert ID values to BigInt in the adapter factory for reads/writes. - Allow BigInt and BigInt[] in query Where values. - **Migration** - If you previously created INTEGER ID columns on MySQL/MSSQL with useNumberId, alter them to BIGINT. - Update application code to use BigInt for IDs (not Number), including query filters and payloads. <!-- End of auto-generated description by cubic. -->
GiteaMirror added the pull-request label 2026-04-13 09:27:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#14394
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?