github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5624] fix: urls without protocol shouldn't be able to satisfy a wildcard origin #14368

New Issue
Closed
opened 2026-04-13 09:26:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:26:27 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/better-auth/better-auth/pull/5624

State: closed
Merged: Yes

Summary by cubic

Hardened origin validation so URLs without a protocol can’t satisfy wildcard trusted origins, preventing malicious callback URL bypasses. Updated docs and tests, plus a small safety tweak to the user table.

  • Bug Fixes
    • Reject callback URLs without protocol for wildcard trustedOrigins; getHost returns null on parse errors and origin check fails safely.
    • Added test to block “malicious.com?.example.com” when trustedOrigins includes "*.example.com".
    • Docs: removed protocol-less wildcard example and added a warning to use a protocol (e.g., https://*.example.com).
    • DB: set user.emailVerified to input: false to prevent client-provided values.
**Original Pull Request:** https://github.com/better-auth/better-auth/pull/5624 **State:** closed **Merged:** Yes --- <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Hardened origin validation so URLs without a protocol can’t satisfy wildcard trusted origins, preventing malicious callback URL bypasses. Updated docs and tests, plus a small safety tweak to the user table. - **Bug Fixes** - Reject callback URLs without protocol for wildcard trustedOrigins; getHost returns null on parse errors and origin check fails safely. - Added test to block “malicious.com?.example.com” when trustedOrigins includes "*.example.com". - Docs: removed protocol-less wildcard example and added a warning to use a protocol (e.g., https://*.example.com). - DB: set user.emailVerified to input: false to prevent client-provided values. <!-- End of auto-generated description by cubic. -->
GiteaMirror added the pull-request label 2026-04-13 09:26:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#14368
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?