github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 08:01:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5419] [MERGED] docs(passkey): added missing important info #14241

New Issue
Closed
opened 2026-04-13 09:22:28 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:22:28 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5419
Author: @ping-maxwell
Created: 10/20/2025
Status: ✅ Merged
Merged: 10/20/2025
Merged by: @himself65

Base: canary ← Head: docs/fix-passkey-info

📝 Commits (1)

  • 0e9ecaf docs(passkey): added missing important info

📊 Changes

1 file changed (+9 additions, -4 deletions)

View changed files

📝 docs/content/docs/plugins/passkey.mdx (+9 -4)

📄 Description

Added important information to the passkey docs regarding rpID and origin which can cause issues if not documented.

Summary by cubic

Clarified passkey docs to prevent WebAuthn misconfig: rpID must be based on the auth server origin and can drop left labels (e.g., www.example.com → example.com) but cannot be an eTLD. Also defined origin as the auth server origin and marked “transports” and “createdAt” as optional in the passkey table.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5419 **Author:** [@ping-maxwell](https://github.com/ping-maxwell) **Created:** 10/20/2025 **Status:** ✅ Merged **Merged:** 10/20/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `docs/fix-passkey-info` --- ### 📝 Commits (1) - [`0e9ecaf`](https://github.com/better-auth/better-auth/commit/0e9ecaf19716d136dd312c4295bdae0c3427d01f) docs(passkey): added missing important info ### 📊 Changes **1 file changed** (+9 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `docs/content/docs/plugins/passkey.mdx` (+9 -4) </details> ### 📄 Description Added important information to the passkey docs regarding `rpID` and `origin` which can cause issues if not documented. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Clarified passkey docs to prevent WebAuthn misconfig: rpID must be based on the auth server origin and can drop left labels (e.g., www.example.com → example.com) but cannot be an eTLD. Also defined origin as the auth server origin and marked “transports” and “createdAt” as optional in the passkey table. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 09:22:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#14241
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?