github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5123] [MERGED] test: add assertions to check for unwanted imports in built output #14038

New Issue
Closed
opened 2026-04-13 09:16:52 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:16:52 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5123
Author: @himself65
Created: 10/6/2025
Status: ✅ Merged
Merged: 10/6/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/10/06/client

📝 Commits (1)

  • 0f96e75 test: add assertions to check for unwanted imports in built output

📊 Changes

1 file changed (+10 additions, -0 deletions)

View changed files

📝 e2e/smoke/test/vite.spec.ts (+10 -0)

📄 Description

Summary by cubic

Add e2e assertions to the Vite client build to fail if the bundle contains server-only imports ("async_hooks", "AsyncLocalStorage") or internal "better-call" createEndpoint. This guards against shipping Node APIs in the browser bundle.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5123 **Author:** [@himself65](https://github.com/himself65) **Created:** 10/6/2025 **Status:** ✅ Merged **Merged:** 10/6/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/10/06/client` --- ### 📝 Commits (1) - [`0f96e75`](https://github.com/better-auth/better-auth/commit/0f96e75341e505f1eb2d18210aba8463b6324007) test: add assertions to check for unwanted imports in built output ### 📊 Changes **1 file changed** (+10 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `e2e/smoke/test/vite.spec.ts` (+10 -0) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Add e2e assertions to the Vite client build to fail if the bundle contains server-only imports ("async_hooks", "AsyncLocalStorage") or internal "better-call" createEndpoint. This guards against shipping Node APIs in the browser bundle. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 09:16:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#14038
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?