github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 16:11:53 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5104] [CLOSED] refactor: move BetterAuthDatabaseOptions to core #14025

New Issue
Closed
opened 2026-04-13 09:16:23 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:16:23 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5104
Author: @himself65
Created: 10/5/2025
Status: ❌ Closed

Base: canary ← Head: himself65/2025/10/05/refactor

📝 Commits (1)

  • 20745f2 refactor: move BetterAuthDatabaseOptions to core

📊 Changes

14 files changed (+158 additions, -81 deletions)

View changed files

📝 packages/better-auth/src/adapters/kysely-adapter/dialect.ts (+1 -1)
📝 packages/better-auth/src/adapters/kysely-adapter/index.ts (+0 -1)
📝 packages/better-auth/src/adapters/kysely-adapter/kysely-adapter.ts (+1 -1)
➖ packages/better-auth/src/adapters/kysely-adapter/types.ts (+0 -1)
📝 packages/better-auth/src/db/get-migration.ts (+1 -1)
📝 packages/better-auth/src/types/options.ts (+6 -68)
📝 packages/core/package.json (+6 -0)
📝 packages/core/src/async_hooks/index.ts (+1 -0)
📝 packages/core/src/db/index.ts (+1 -0)
📝 packages/core/src/db/type.ts (+2 -0)
📝 packages/core/src/types/index.ts (+5 -1)
📝 packages/core/src/types/init-options.ts (+94 -1)
📝 packages/core/tsconfig.json (+1 -1)
📝 pnpm-lock.yaml (+39 -5)

📄 Description

Summary by cubic

Moved BetterAuthDatabaseOptions and KyselyDatabaseType into core to unify database typing across packages. No API changes; existing configs continue to work.

  • Refactors

    • Centralized BetterAuthDatabaseOptions and KyselyDatabaseType in @better-auth/core; export KyselyDatabaseType from core/db.
    • Replaced BetterAuthOptions.database union with BetterAuthDatabaseOptions; removed adapters/kysely-adapter/types.ts.
    • Updated imports in Kysely adapter and migration helpers; added explicit type references in core and simplified core tsconfig types.

  • Dependencies

    • Added better-sqlite3 and kysely as core peerDependencies (and devDependencies).
    • Updated pnpm lock to reflect new versions.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5104 **Author:** [@himself65](https://github.com/himself65) **Created:** 10/5/2025 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `himself65/2025/10/05/refactor` --- ### 📝 Commits (1) - [`20745f2`](https://github.com/better-auth/better-auth/commit/20745f292dbec887d1e744370c37c5b8ef2aa6f3) refactor: move `BetterAuthDatabaseOptions` to core ### 📊 Changes **14 files changed** (+158 additions, -81 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/adapters/kysely-adapter/dialect.ts` (+1 -1) 📝 `packages/better-auth/src/adapters/kysely-adapter/index.ts` (+0 -1) 📝 `packages/better-auth/src/adapters/kysely-adapter/kysely-adapter.ts` (+1 -1) ➖ `packages/better-auth/src/adapters/kysely-adapter/types.ts` (+0 -1) 📝 `packages/better-auth/src/db/get-migration.ts` (+1 -1) 📝 `packages/better-auth/src/types/options.ts` (+6 -68) 📝 `packages/core/package.json` (+6 -0) 📝 `packages/core/src/async_hooks/index.ts` (+1 -0) 📝 `packages/core/src/db/index.ts` (+1 -0) 📝 `packages/core/src/db/type.ts` (+2 -0) 📝 `packages/core/src/types/index.ts` (+5 -1) 📝 `packages/core/src/types/init-options.ts` (+94 -1) 📝 `packages/core/tsconfig.json` (+1 -1) 📝 `pnpm-lock.yaml` (+39 -5) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Moved BetterAuthDatabaseOptions and KyselyDatabaseType into core to unify database typing across packages. No API changes; existing configs continue to work. - **Refactors** - Centralized BetterAuthDatabaseOptions and KyselyDatabaseType in @better-auth/core; export KyselyDatabaseType from core/db. - Replaced BetterAuthOptions.database union with BetterAuthDatabaseOptions; removed adapters/kysely-adapter/types.ts. - Updated imports in Kysely adapter and migration helpers; added explicit type references in core and simplified core tsconfig types. - **Dependencies** - Added better-sqlite3 and kysely as core peerDependencies (and devDependencies). - Updated pnpm lock to reflect new versions. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 09:16:23 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#14025
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?