github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5010] [MERGED] chore: fix nextjs warnings #13963

New Issue
Closed
opened 2026-04-13 09:14:29 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:14:29 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5010
Author: @himself65
Created: 10/1/2025
Status: ✅ Merged
Merged: 10/1/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/09/30/circular-deps

📝 Commits (2)

  • 6833f21 chore: fix circular deps
  • 9e81cc2 chore: fix next.js warnings

📊 Changes

2 files changed (+3 additions, -5 deletions)

View changed files

📝 packages/better-auth/src/telemetry/detectors/detect-system-info.ts (+1 -1)
📝 packages/core/src/async_hooks/index.ts (+2 -4)

📄 Description

Summary by cubic

Fixes a circular dependency in core by correcting the dynamic import of node:async_hooks. Uses proper Vite and Webpack ignore hints so the module loads at runtime and isn’t statically bundled.

  • Bug Fixes
    • Replaced invalid "@webpackIgnore" with "webpackIgnore: true" and added separate /* @vite-ignore / and / webpackIgnore: true */ comments on the import().

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5010 **Author:** [@himself65](https://github.com/himself65) **Created:** 10/1/2025 **Status:** ✅ Merged **Merged:** 10/1/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/09/30/circular-deps` --- ### 📝 Commits (2) - [`6833f21`](https://github.com/better-auth/better-auth/commit/6833f213b7b4a91b7dfd4e759d78eb7a1a88e8bb) chore: fix circular deps - [`9e81cc2`](https://github.com/better-auth/better-auth/commit/9e81cc208847e15d1bb1b0c5067bf110af50bb4e) chore: fix next.js warnings ### 📊 Changes **2 files changed** (+3 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/telemetry/detectors/detect-system-info.ts` (+1 -1) 📝 `packages/core/src/async_hooks/index.ts` (+2 -4) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Fixes a circular dependency in core by correcting the dynamic import of node:async_hooks. Uses proper Vite and Webpack ignore hints so the module loads at runtime and isn’t statically bundled. - **Bug Fixes** - Replaced invalid "@webpackIgnore" with "webpackIgnore: true" and added separate /* @vite-ignore */ and /* webpackIgnore: true */ comments on the import(). <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 09:14:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#13963
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?