github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4917] fix: allow signIn.social by utilizing discovery url #13903

New Issue
Open
opened 2026-04-13 09:12:12 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:12:12 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4917
Author: @dvanmali
Created: 9/25/2025
Status: 🔄 Open

Base: main ← Head: genericOAuth

📝 Commits (3)

  • b48babc fix: allow signIn.social by utilizing discovery url
  • 831efac fix: shrink by using default provider
  • 1ba326f fix: properly delegates additional params to createAuthorizationUrl function

📊 Changes

2 files changed (+33 additions, -14 deletions)

View changed files

📝 packages/better-auth/src/plugins/generic-oauth/generic-oauth.test.ts (+14 -0)
📝 packages/better-auth/src/plugins/generic-oauth/index.ts (+19 -14)

📄 Description

Fixes issue of authorization url not being discovered by social provider.

This addition also enables signIn.social beyond just signIn.oauth2.

Closes: #3278

Summary by cubic

Use OIDC discovery to resolve the authorization URL in generic OAuth, fixing social login flows. Enables signIn.social for providers configured with discoveryUrl.

  • Bug Fixes
    • Fetch authorization_endpoint from discoveryUrl when provided.
    • Apply authorizationUrlParams to the discovered authorization URL.
    • Add test covering signIn.social with a discovered auth URL and correct redirect.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4917 **Author:** [@dvanmali](https://github.com/dvanmali) **Created:** 9/25/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `genericOAuth` --- ### 📝 Commits (3) - [`b48babc`](https://github.com/better-auth/better-auth/commit/b48babce9954b09aaba5b9a5de16e95f812bdfc4) fix: allow signIn.social by utilizing discovery url - [`831efac`](https://github.com/better-auth/better-auth/commit/831efac7ce9f8538bec1a41285af9264e14bf88c) fix: shrink by using default provider - [`1ba326f`](https://github.com/better-auth/better-auth/commit/1ba326f654dbe4fd6a43431de1e3000127766587) fix: properly delegates additional params to createAuthorizationUrl function ### 📊 Changes **2 files changed** (+33 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/generic-oauth/generic-oauth.test.ts` (+14 -0) 📝 `packages/better-auth/src/plugins/generic-oauth/index.ts` (+19 -14) </details> ### 📄 Description Fixes issue of authorization url not being discovered by social provider. This addition also enables `signIn.social` beyond just `signIn.oauth2`. Closes: #3278 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Use OIDC discovery to resolve the authorization URL in generic OAuth, fixing social login flows. Enables signIn.social for providers configured with discoveryUrl. - **Bug Fixes** - Fetch authorization_endpoint from discoveryUrl when provided. - Apply authorizationUrlParams to the discovered authorization URL. - Add test covering signIn.social with a discovered auth URL and correct redirect. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 09:12:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#13903
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?