github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 08:01:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4915] [MERGED] fix: tests failing due to clock drift #13901

New Issue
Closed
opened 2026-04-13 09:12:09 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:12:09 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4915
Author: @dvanmali
Created: 9/25/2025
Status: ✅ Merged
Merged: 9/25/2025
Merged by: @himself65

Base: canary ← Head: timing

📝 Commits (1)

  • 7d18308 fix: tests failingdue to clock drift

📊 Changes

1 file changed (+10 additions, -6 deletions)

View changed files

📝 packages/better-auth/src/db/internal-adapter.test.ts (+10 -6)

📄 Description

Fix: #4910

Summary by cubic

Fix failing adapter tests caused by clock drift by computing expected expirations from the current time and allowing up to 1s drift. Addresses #4910.

  • Bug Fixes
    • Replace hardcoded 7-day TTL with expiresAt derived from Date.now and compare using seconds.
    • Add up-to-1s drift tolerance for session and token TTL checks to prevent CI flakiness.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4915 **Author:** [@dvanmali](https://github.com/dvanmali) **Created:** 9/25/2025 **Status:** ✅ Merged **Merged:** 9/25/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `timing` --- ### 📝 Commits (1) - [`7d18308`](https://github.com/better-auth/better-auth/commit/7d183088c15d1cd8d780fe2cc3afc972bf1d48e4) fix: tests failingdue to clock drift ### 📊 Changes **1 file changed** (+10 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/db/internal-adapter.test.ts` (+10 -6) </details> ### 📄 Description Fix: #4910 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fix failing adapter tests caused by clock drift by computing expected expirations from the current time and allowing up to 1s drift. Addresses #4910. - **Bug Fixes** - Replace hardcoded 7-day TTL with expiresAt derived from Date.now and compare using seconds. - Add up-to-1s drift tolerance for session and token TTL checks to prevent CI flakiness. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 09:12:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#13901
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?