github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4809] refactor(admin): default value for both limit and offset and always return them #13834

New Issue
Open
opened 2026-04-13 09:10:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:10:20 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4809
Author: @hieudien14310
Created: 9/22/2025
Status: 🔄 Open

Base: main ← Head: refactor/admin-list-user

📝 Commits (9)

  • f6bba6f refactor: default value for both offset and limit
  • 42e395b refactor: re-order the statement to display the description on OpenApi
  • bd6ade7 refactor: fix code
  • ff2dbc7 refactor: fix wrong default offset value
  • 1cd588b Merge branch 'canary' into refactor/admin-list-user
  • a5e4de2 refactor: using Promise.all to improve performance
  • 1f0a0e1 refactor: remove optional
  • c4f8376 test: add test for admin list users with default offset and limit values
  • 7862817 Merge branch 'canary' into refactor/admin-list-user

📊 Changes

2 files changed (+61 additions, -38 deletions)

View changed files

📝 packages/better-auth/src/plugins/admin/admin.test.ts (+14 -0)
📝 packages/better-auth/src/plugins/admin/admin.ts (+47 -38)

📄 Description

Summary by cubic

Set default pagination for the admin list users endpoint (limit=10, offset=0) and always include limit/offset in the response. Also improved OpenAPI docs and simplified parameter handling.

  • Refactors
    • Added defaults: limit=10, offset=0; both accept string or number.
    • Always return offset and limit in success and error responses.
    • Short-circuit with empty result when limit <= 0 (skips DB call).
    • Pass numeric limit/offset to the adapter.
    • Reordered Zod .meta/.optional to ensure OpenAPI descriptions render.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4809 **Author:** [@hieudien14310](https://github.com/hieudien14310) **Created:** 9/22/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `refactor/admin-list-user` --- ### 📝 Commits (9) - [`f6bba6f`](https://github.com/better-auth/better-auth/commit/f6bba6f92abecbec7edb1873ad917089a626ef33) refactor: default value for both offset and limit - [`42e395b`](https://github.com/better-auth/better-auth/commit/42e395be0ef64d8aae7c0645e8550f792137c645) refactor: re-order the statement to display the description on OpenApi - [`bd6ade7`](https://github.com/better-auth/better-auth/commit/bd6ade75ded6ed6af4b4d730020165d05282e309) refactor: fix code - [`ff2dbc7`](https://github.com/better-auth/better-auth/commit/ff2dbc7b853328b53cead02e72dbfb08b3b1955b) refactor: fix wrong default offset value - [`1cd588b`](https://github.com/better-auth/better-auth/commit/1cd588b02194b4fb2209df5183328489164e6d47) Merge branch 'canary' into refactor/admin-list-user - [`a5e4de2`](https://github.com/better-auth/better-auth/commit/a5e4de2c3899635f7c8ad7758bcbc37524768e36) refactor: using Promise.all to improve performance - [`1f0a0e1`](https://github.com/better-auth/better-auth/commit/1f0a0e12274de401a864a17f040371c335705c3d) refactor: remove optional - [`c4f8376`](https://github.com/better-auth/better-auth/commit/c4f837636cd266aa9e851a75a2c78be094789993) test: add test for admin list users with default offset and limit values - [`7862817`](https://github.com/better-auth/better-auth/commit/7862817221f46990f293b4eb32a01afba12cd2c3) Merge branch 'canary' into refactor/admin-list-user ### 📊 Changes **2 files changed** (+61 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/admin/admin.test.ts` (+14 -0) 📝 `packages/better-auth/src/plugins/admin/admin.ts` (+47 -38) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Set default pagination for the admin list users endpoint (limit=10, offset=0) and always include limit/offset in the response. Also improved OpenAPI docs and simplified parameter handling. - **Refactors** - Added defaults: limit=10, offset=0; both accept string or number. - Always return offset and limit in success and error responses. - Short-circuit with empty result when limit <= 0 (skips DB call). - Pass numeric limit/offset to the adapter. - Reordered Zod .meta/.optional to ensure OpenAPI descriptions render. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 09:10:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#13834
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?