github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4800] [MERGED] feat(passkey): validate multiple passkey origins #13830

New Issue
Closed
opened 2026-04-13 09:10:16 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:10:16 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4800
Author: @kevcube
Created: 9/21/2025
Status: ✅ Merged
Merged: 9/21/2025
Merged by: @Bekacru

Base: canary ← Head: passkey_allow_origin_list

📝 Commits (1)

  • 6998c77 feat: validate multiple passkey origins

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 packages/better-auth/src/plugins/passkey/index.ts (+4 -4)

📄 Description

In simplewebauthn, this can be string | string[], therefore we should allow the same.

Summary by cubic

Allow configuring multiple passkey origins by accepting string or string[] for PasskeyOptions.origin. This matches SimpleWebAuthn and enables validation across multiple domains while staying backward compatible with single-origin setups.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4800 **Author:** [@kevcube](https://github.com/kevcube) **Created:** 9/21/2025 **Status:** ✅ Merged **Merged:** 9/21/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `passkey_allow_origin_list` --- ### 📝 Commits (1) - [`6998c77`](https://github.com/better-auth/better-auth/commit/6998c7715b0e18520cbdaa28ad8b2a3c38ab7124) feat: validate multiple passkey origins ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/passkey/index.ts` (+4 -4) </details> ### 📄 Description In simplewebauthn, this can be `string | string[]`, therefore we should allow the same. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Allow configuring multiple passkey origins by accepting string or string[] for PasskeyOptions.origin. This matches SimpleWebAuthn and enables validation across multiple domains while staying backward compatible with single-origin setups. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 09:10:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#13830
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?