github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4659] [CLOSED] chore(test): fix flaky CI tests #13756

New Issue
Closed
opened 2026-04-13 09:07:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:07:55 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4659
Author: @Bekacru
Created: 9/14/2025
Status: ❌ Closed

Base: canary ← Head: fix/flaky-test

📝 Commits (6)

📊 Changes

3 files changed (+85 additions, -176 deletions)

View changed files

📝 packages/better-auth/src/adapters/prisma-adapter/test/number-id-tests/adapter.prisma.number-id.test.ts (+34 -37)
➖ packages/better-auth/src/adapters/prisma-adapter/test/number-id-tests/get-adapter.ts (+0 -27)
📝 packages/better-auth/src/adapters/test.ts (+51 -112)

📄 Description

Summary by cubic

Stabilized the Prisma adapter number-id tests in CI by isolating state and removing external schema/state dependencies. Tests now run reliably and are retried to catch intermittent failures.

  • Bug Fixes
    • Inlined Prisma adapter setup; removed get-adapter.ts.
    • Added beforeEach DB cleanup and sqlite_sequence resets for deterministic IDs.
    • Dropped pushPrismaSchema/state polling and fs watchers.
    • Wrapped suite with describe({ repeats: 3 }) to surface flakiness.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4659 **Author:** [@Bekacru](https://github.com/Bekacru) **Created:** 9/14/2025 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `fix/flaky-test` --- ### 📝 Commits (6) - [`a35f1bd`](https://github.com/better-auth/better-auth/commit/a35f1bdf74c2805d1f735aae74af244cbc7c5fbd) wrap test and use before each - [`10fe71e`](https://github.com/better-auth/better-auth/commit/10fe71ef7303578bece12d577f21e3d953d406bb) repeat only once - [`7febe63`](https://github.com/better-auth/better-auth/commit/7febe63015d6146eb25f5007e296ef2ab3ea4eec) chore: use vitest - [`6caf9b3`](https://github.com/better-auth/better-auth/commit/6caf9b3dad12c1d06659cab1a752eed24379ad63) remove repeat - [`c177298`](https://github.com/better-auth/better-auth/commit/c177298f837410c86800fed8bdcaa62e9669450c) test: fix - [`577d5d0`](https://github.com/better-auth/better-auth/commit/577d5d0260135a785e024172d91ccabfcd36c1a7) test: fix ### 📊 Changes **3 files changed** (+85 additions, -176 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/adapters/prisma-adapter/test/number-id-tests/adapter.prisma.number-id.test.ts` (+34 -37) ➖ `packages/better-auth/src/adapters/prisma-adapter/test/number-id-tests/get-adapter.ts` (+0 -27) 📝 `packages/better-auth/src/adapters/test.ts` (+51 -112) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Stabilized the Prisma adapter number-id tests in CI by isolating state and removing external schema/state dependencies. Tests now run reliably and are retried to catch intermittent failures. - **Bug Fixes** - Inlined Prisma adapter setup; removed get-adapter.ts. - Added beforeEach DB cleanup and sqlite_sequence resets for deterministic IDs. - Dropped pushPrismaSchema/state polling and fs watchers. - Wrapped suite with describe({ repeats: 3 }) to surface flakiness. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 09:07:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#13756
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?