github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4481] [MERGED] fix: sidebar content and mobile nav #13650

New Issue
Closed
opened 2026-04-13 09:02:53 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:02:53 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4481
Author: @bytaesu
Created: 9/6/2025
Status: ✅ Merged
Merged: 9/9/2025
Merged by: @himself65

Base: canary ← Head: fix/sidebar-mobile-nav

📝 Commits (2)

  • 597359b fix: prevent unexpected nav on divider using empty href
  • a1eabcc fix: render mobile nav menu correctly

📊 Changes

2 files changed (+41 additions, -29 deletions)

View changed files

📝 docs/components/nav-mobile.tsx (+29 -17)
📝 docs/components/sidebar-content.tsx (+12 -12)

📄 Description

This PR removes incorrect href assignments in the sidebar content and fixes the mobile navigation to display the menu correctly.

Only the Docs website has been changed, the main packages remain unaffected.

Before:

https://github.com/user-attachments/assets/5de20b81-4dee-4367-b4c2-855f8906eb15

After:

https://github.com/user-attachments/assets/041d2df5-9d29-4746-9a89-bdb2cb8b25a0

Summary by cubic

Stops accidental navigation in the docs sidebar and fixes the mobile menu rendering. Group headers are now non-clickable dividers; only real items navigate.

  • Bug Fixes
    • Sidebar: cleared href on group headers to prevent navigation.
    • Mobile nav: render group headers as non-interactive and fix item borders; links still close the menu on tap.
    • Scope: docs site only; no package changes.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4481 **Author:** [@bytaesu](https://github.com/bytaesu) **Created:** 9/6/2025 **Status:** ✅ Merged **Merged:** 9/9/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `fix/sidebar-mobile-nav` --- ### 📝 Commits (2) - [`597359b`](https://github.com/better-auth/better-auth/commit/597359b5c11c92f56f2601b24d9d097a1f6db88a) fix: prevent unexpected nav on divider using empty href - [`a1eabcc`](https://github.com/better-auth/better-auth/commit/a1eabccf80679abe181c385c028a269de5b56654) fix: render mobile nav menu correctly ### 📊 Changes **2 files changed** (+41 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `docs/components/nav-mobile.tsx` (+29 -17) 📝 `docs/components/sidebar-content.tsx` (+12 -12) </details> ### 📄 Description --- This PR removes incorrect href assignments in the sidebar content and fixes the mobile navigation to display the menu correctly. Only the Docs website has been changed, the main packages remain unaffected. --- ### **Before:** https://github.com/user-attachments/assets/5de20b81-4dee-4367-b4c2-855f8906eb15 ### **After:** https://github.com/user-attachments/assets/041d2df5-9d29-4746-9a89-bdb2cb8b25a0 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Stops accidental navigation in the docs sidebar and fixes the mobile menu rendering. Group headers are now non-clickable dividers; only real items navigate. - **Bug Fixes** - Sidebar: cleared href on group headers to prevent navigation. - Mobile nav: render group headers as non-interactive and fix item borders; links still close the menu on tap. - Scope: docs site only; no package changes. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 09:02:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#13650
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?