github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-08-31 12:32:52 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4469] [MERGED] e2e: integration test for solid-js #13645

New Issue
Closed
opened 2026-04-13 09:02:46 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:02:46 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4469
Author: @himself65
Created: 9/5/2025
Status: ✅ Merged
Merged: 9/8/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/09/04/e2e

📝 Commits (10+)

📊 Changes

24 files changed (+1104 additions, -40 deletions)

View changed files

📝 biome.json (+2 -1)
📝 e2e/integration/package.json (+1 -2)
➕ e2e/integration/solid-vinxi/.gitignore (+28 -0)
➕ e2e/integration/solid-vinxi/app.config.ts (+5 -0)
➕ e2e/integration/solid-vinxi/e2e/test.spec.ts (+34 -0)
➕ e2e/integration/solid-vinxi/e2e/utils.ts (+63 -0)
➕ e2e/integration/solid-vinxi/package.json (+21 -0)
➕ e2e/integration/solid-vinxi/public/favicon.ico (+0 -0)
➕ e2e/integration/solid-vinxi/src/app.tsx (+14 -0)
➕ e2e/integration/solid-vinxi/src/entry-client.tsx (+4 -0)
➕ e2e/integration/solid-vinxi/src/entry-server.tsx (+21 -0)
➕ e2e/integration/solid-vinxi/src/global.d.ts (+1 -0)
➕ e2e/integration/solid-vinxi/src/lib/auth-client.ts (+19 -0)
➕ e2e/integration/solid-vinxi/src/lib/auth.ts (+26 -0)
➕ e2e/integration/solid-vinxi/src/routes/[...404].tsx (+27 -0)
➕ e2e/integration/solid-vinxi/src/routes/api/auth/[...all].ts (+10 -0)
➕ e2e/integration/solid-vinxi/src/routes/index.tsx (+13 -0)
➕ e2e/integration/solid-vinxi/tsconfig.json (+16 -0)
➕ e2e/integration/test-utils/package.json (+11 -0)
➕ e2e/integration/test-utils/src/playwright.ts (+8 -0)

...and 4 more files

📄 Description

Summary by cubic

Add a SolidStart (Vinxi) end-to-end test to verify Better Auth’s email/password sign-in and session cookie behavior. Includes a minimal Solid app and a Node auth server exercised via Playwright.

  • New Features

    • New e2e app at e2e/integration/solid-vinxi with SSR enabled.
    • Playwright spins up an in-memory SQLite Better Auth server, seeds a user, and runs vinxi dev.
    • Test signs in via the Solid client SDK and asserts the better-auth.session_token cookie.
    • Utilities handle process start/stop using terminate to prevent orphaned children.

  • Dependencies

    • Adds SolidStart/Vinxi, solid-js, better-sqlite3, and terminate to the e2e workspace.
    • Updates pnpm-lock.yaml.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4469 **Author:** [@himself65](https://github.com/himself65) **Created:** 9/5/2025 **Status:** ✅ Merged **Merged:** 9/8/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/09/04/e2e` --- ### 📝 Commits (10+) - [`b958b2e`](https://github.com/better-auth/better-auth/commit/b958b2e6401a067643cf7c1d8665eba03abac2ff) feat: initial setup - [`3521e72`](https://github.com/better-auth/better-auth/commit/3521e724e2396bf6cbcb2bf39e1a067a76667a3a) feat: setup - [`06d655e`](https://github.com/better-auth/better-auth/commit/06d655e958869cd0c51f618a5ff71be8d80a813f) fix: type - [`ed53bdb`](https://github.com/better-auth/better-auth/commit/ed53bdbc7380f49974bd08ff7d0a3ed0f7d30b29) fix: import solid - [`be5fde0`](https://github.com/better-auth/better-auth/commit/be5fde077b6f0371babc1355379d1ff0a07d56a1) feat: abstract - [`f2678d6`](https://github.com/better-auth/better-auth/commit/f2678d606d852aa129a23445512ccbbb9aabf69e) Merge branch 'canary' into himself65/2025/09/04/e2e - [`29c0341`](https://github.com/better-auth/better-auth/commit/29c0341946e0e67c1cca36f17c6d9435b1ad22f4) chore: update code - [`6fd6dba`](https://github.com/better-auth/better-auth/commit/6fd6dbaef91410e5bc4784dadb2ca8ae09e8060d) feat: update code - [`70286cf`](https://github.com/better-auth/better-auth/commit/70286cfab85413f9837c89151b758f81202d7f5d) fix: deps - [`6fa4a17`](https://github.com/better-auth/better-auth/commit/6fa4a179ddb14c46031221abbbdbc60eedfa5bb1) fix: type module ### 📊 Changes **24 files changed** (+1104 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `biome.json` (+2 -1) 📝 `e2e/integration/package.json` (+1 -2) ➕ `e2e/integration/solid-vinxi/.gitignore` (+28 -0) ➕ `e2e/integration/solid-vinxi/app.config.ts` (+5 -0) ➕ `e2e/integration/solid-vinxi/e2e/test.spec.ts` (+34 -0) ➕ `e2e/integration/solid-vinxi/e2e/utils.ts` (+63 -0) ➕ `e2e/integration/solid-vinxi/package.json` (+21 -0) ➕ `e2e/integration/solid-vinxi/public/favicon.ico` (+0 -0) ➕ `e2e/integration/solid-vinxi/src/app.tsx` (+14 -0) ➕ `e2e/integration/solid-vinxi/src/entry-client.tsx` (+4 -0) ➕ `e2e/integration/solid-vinxi/src/entry-server.tsx` (+21 -0) ➕ `e2e/integration/solid-vinxi/src/global.d.ts` (+1 -0) ➕ `e2e/integration/solid-vinxi/src/lib/auth-client.ts` (+19 -0) ➕ `e2e/integration/solid-vinxi/src/lib/auth.ts` (+26 -0) ➕ `e2e/integration/solid-vinxi/src/routes/[...404].tsx` (+27 -0) ➕ `e2e/integration/solid-vinxi/src/routes/api/auth/[...all].ts` (+10 -0) ➕ `e2e/integration/solid-vinxi/src/routes/index.tsx` (+13 -0) ➕ `e2e/integration/solid-vinxi/tsconfig.json` (+16 -0) ➕ `e2e/integration/test-utils/package.json` (+11 -0) ➕ `e2e/integration/test-utils/src/playwright.ts` (+8 -0) _...and 4 more files_ </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Add a SolidStart (Vinxi) end-to-end test to verify Better Auth’s email/password sign-in and session cookie behavior. Includes a minimal Solid app and a Node auth server exercised via Playwright. - **New Features** - New e2e app at e2e/integration/solid-vinxi with SSR enabled. - Playwright spins up an in-memory SQLite Better Auth server, seeds a user, and runs vinxi dev. - Test signs in via the Solid client SDK and asserts the better-auth.session_token cookie. - Utilities handle process start/stop using terminate to prevent orphaned children. - **Dependencies** - Adds SolidStart/Vinxi, solid-js, better-sqlite3, and terminate to the e2e workspace. - Updates pnpm-lock.yaml. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 09:02:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#13645