github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-06-03 12:57:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4440] [MERGED] fix: add missing closing parenthesis in PostgreSQL timestamp definition #13632

New Issue
Closed
opened 2026-04-13 09:02:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:02:20 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4440
Author: @JuanPabloGilA
Created: 9/4/2025
Status: ✅ Merged
Merged: 9/4/2025
Merged by: @himself65

Base: main ← Head: main

📝 Commits (1)

  • 3b58830 fix: add missing closing parenthesis in PostgreSQL timestamp definition

📊 Changes

4 files changed (+74 additions, -38 deletions)

View changed files

📝 packages/cli/src/generators/drizzle.ts (+1 -1)
📝 packages/cli/test/__snapshots__/auth-schema-number-id.txt (+24 -12)
📝 packages/cli/test/__snapshots__/auth-schema-pg-passkey.txt (+25 -13)
📝 packages/cli/test/__snapshots__/auth-schema.txt (+24 -12)

📄 Description

  • Updated test snapshots to reflect the corrected generated code
  • All tests now pass successfully

Fixes issue where PostgreSQL timestamp fields had invalid syntax:

  • Before: timestamp('name')
  • After: timestamp('name', { withTimezone: true })

Summary by cubic

Fix PostgreSQL timestamp generation in the CLI by adding the missing closing parenthesis and emitting timestamp('name', { withTimezone: true }) for timestamp fields. Updated test snapshots to match the corrected output.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4440 **Author:** [@JuanPabloGilA](https://github.com/JuanPabloGilA) **Created:** 9/4/2025 **Status:** ✅ Merged **Merged:** 9/4/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`3b58830`](https://github.com/better-auth/better-auth/commit/3b58830736d6596afbef089148364f2209cc804a) fix: add missing closing parenthesis in PostgreSQL timestamp definition ### 📊 Changes **4 files changed** (+74 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `packages/cli/src/generators/drizzle.ts` (+1 -1) 📝 `packages/cli/test/__snapshots__/auth-schema-number-id.txt` (+24 -12) 📝 `packages/cli/test/__snapshots__/auth-schema-pg-passkey.txt` (+25 -13) 📝 `packages/cli/test/__snapshots__/auth-schema.txt` (+24 -12) </details> ### 📄 Description - Updated test snapshots to reflect the corrected generated code - All tests now pass successfully Fixes issue where PostgreSQL timestamp fields had invalid syntax: - Before: timestamp('name') - After: timestamp('name', { withTimezone: true }) <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fix PostgreSQL timestamp generation in the CLI by adding the missing closing parenthesis and emitting timestamp('name', { withTimezone: true }) for timestamp fields. Updated test snapshots to match the corrected output. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 09:02:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#13632
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?