github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4415] [MERGED] fix: cloudflare build warning with node:sqlite #13618

New Issue
Closed
opened 2026-04-13 09:01:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 09:01:58 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4415
Author: @himself65
Created: 9/4/2025
Status: ✅ Merged
Merged: 9/4/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/09/03/build

📝 Commits (2)

  • 8bf3cbe fix: cloudflare build warning with node:sqlite
  • 12a8132 fix: cloudflare build warning with node:sqlite

📊 Changes

2 files changed (+23 additions, -1 deletions)

View changed files

📝 e2e/smoke/test/cloudflare.spec.ts (+15 -0)
📝 packages/better-auth/src/adapters/kysely-adapter/dialect.ts (+8 -1)

📄 Description

Fixes: https://github.com/better-auth/better-auth/issues/4404

Summary by cubic

Prevents Cloudflare build warnings by stopping Vite/Webpack from pre-bundling node:sqlite in the Kysely adapter. Uses dynamic import hints so sqlite is loaded only at runtime. Fixes better-auth/better-auth#4404.

  • Bug Fixes
    • Added /* @vite-ignore / and / webpackIgnore: true */ to the node:sqlite dynamic import inside the existing try/catch.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4415 **Author:** [@himself65](https://github.com/himself65) **Created:** 9/4/2025 **Status:** ✅ Merged **Merged:** 9/4/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/09/03/build` --- ### 📝 Commits (2) - [`8bf3cbe`](https://github.com/better-auth/better-auth/commit/8bf3cbeae83271456e281bf02ded868ad60bb851) fix: cloudflare build warning with `node:sqlite` - [`12a8132`](https://github.com/better-auth/better-auth/commit/12a81323b4b1d9ca3492be06c05739db47eb7a18) fix: cloudflare build warning with `node:sqlite` ### 📊 Changes **2 files changed** (+23 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `e2e/smoke/test/cloudflare.spec.ts` (+15 -0) 📝 `packages/better-auth/src/adapters/kysely-adapter/dialect.ts` (+8 -1) </details> ### 📄 Description Fixes: https://github.com/better-auth/better-auth/issues/4404 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Prevents Cloudflare build warnings by stopping Vite/Webpack from pre-bundling node:sqlite in the Kysely adapter. Uses dynamic import hints so sqlite is loaded only at runtime. Fixes better-auth/better-auth#4404. - **Bug Fixes** - Added /* @vite-ignore */ and /* webpackIgnore: true */ to the node:sqlite dynamic import inside the existing try/catch. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 09:01:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#13618
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?