github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 06:16:18 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4296] [MERGED] chore: enable lint rule noTsIgnore #13545

New Issue
Closed
opened 2026-04-13 08:59:42 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 08:59:42 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4296
Author: @himself65
Created: 8/28/2025
Status: ✅ Merged
Merged: 8/28/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/08/28/type-check

📝 Commits (3)

  • 0fb057d chore: enable lint rule noTsIgnore
  • 61ffaa9 chore: enable lint rule noTsIgnore
  • e0cb11c Merge branch 'canary' into himself65/2025/08/28/type-check

📊 Changes

28 files changed (+47 additions, -92 deletions)

View changed files

📝 biome.json (+2 -1)
📝 demo/nextjs/app/dashboard/user-card.tsx (+0 -1)
📝 demo/nextjs/app/oauth/authorize/page.tsx (+1 -1)
📝 demo/nextjs/hooks/use-toast.ts (+1 -1)
📝 docs/app/changelogs/[[...slug]]/page.tsx (+0 -1)
📝 docs/components/nav-mobile.tsx (+0 -1)
📝 docs/scripts/endpoint-to-doc/index.ts (+4 -4)
📝 packages/better-auth/src/adapters/create-adapter/index.ts (+1 -1)
📝 packages/better-auth/src/adapters/create-adapter/test/create-adapter.test.ts (+2 -18)
📝 packages/better-auth/src/adapters/drizzle-adapter/test/adapter.drizzle.test.ts (+2 -2)
📝 packages/better-auth/src/adapters/kysely-adapter/bun-sqlite-dialect.ts (+7 -10)
📝 packages/better-auth/src/adapters/kysely-adapter/dialect.ts (+1 -1)
📝 packages/better-auth/src/adapters/kysely-adapter/node-sqlite-dialect.ts (+7 -9)
📝 packages/better-auth/src/adapters/memory-adapter/memory-adapter.ts (+2 -2)
📝 packages/better-auth/src/adapters/test.ts (+1 -2)
📝 packages/better-auth/src/api/rate-limiter/rate-limiter.test.ts (+0 -1)
📝 packages/better-auth/src/api/routes/update-user.test.ts (+1 -1)
📝 packages/better-auth/src/db/utils.ts (+1 -1)
📝 packages/better-auth/src/plugins/api-key/routes/create-api-key.ts (+2 -5)
📝 packages/better-auth/src/plugins/api-key/routes/get-api-key.ts (+1 -4)

...and 8 more files

📄 Description

Summary by cubic

Enable Biome lint rule noTsIgnore and clean up suppressions across the repo. Replaced @ts-ignore with @ts-expect-error where errors are intentional, removed unnecessary suppressions, and made minor typing tweaks. No runtime changes.

  • Refactors
    • Set biome lint rule suspicious.noTsIgnore to error.
    • Replaced @ts-ignore with @ts-expect-error in adapters, API key routes, Kysely SQLite dialects, CLI, docs, demo, and tests.
    • Removed unused suppressions and adjusted types (e.g., safeJSONParse inputs, bun:sqlite type imports, number ID test types).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4296 **Author:** [@himself65](https://github.com/himself65) **Created:** 8/28/2025 **Status:** ✅ Merged **Merged:** 8/28/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/08/28/type-check` --- ### 📝 Commits (3) - [`0fb057d`](https://github.com/better-auth/better-auth/commit/0fb057d333a8ac6133f9cb55277e479f32604d54) chore: enable lint rule `noTsIgnore` - [`61ffaa9`](https://github.com/better-auth/better-auth/commit/61ffaa9c6141363291580888313e427132b702ec) chore: enable lint rule `noTsIgnore` - [`e0cb11c`](https://github.com/better-auth/better-auth/commit/e0cb11c03680204842a81e74109c813da599089e) Merge branch 'canary' into himself65/2025/08/28/type-check ### 📊 Changes **28 files changed** (+47 additions, -92 deletions) <details> <summary>View changed files</summary> 📝 `biome.json` (+2 -1) 📝 `demo/nextjs/app/dashboard/user-card.tsx` (+0 -1) 📝 `demo/nextjs/app/oauth/authorize/page.tsx` (+1 -1) 📝 `demo/nextjs/hooks/use-toast.ts` (+1 -1) 📝 `docs/app/changelogs/[[...slug]]/page.tsx` (+0 -1) 📝 `docs/components/nav-mobile.tsx` (+0 -1) 📝 `docs/scripts/endpoint-to-doc/index.ts` (+4 -4) 📝 `packages/better-auth/src/adapters/create-adapter/index.ts` (+1 -1) 📝 `packages/better-auth/src/adapters/create-adapter/test/create-adapter.test.ts` (+2 -18) 📝 `packages/better-auth/src/adapters/drizzle-adapter/test/adapter.drizzle.test.ts` (+2 -2) 📝 `packages/better-auth/src/adapters/kysely-adapter/bun-sqlite-dialect.ts` (+7 -10) 📝 `packages/better-auth/src/adapters/kysely-adapter/dialect.ts` (+1 -1) 📝 `packages/better-auth/src/adapters/kysely-adapter/node-sqlite-dialect.ts` (+7 -9) 📝 `packages/better-auth/src/adapters/memory-adapter/memory-adapter.ts` (+2 -2) 📝 `packages/better-auth/src/adapters/test.ts` (+1 -2) 📝 `packages/better-auth/src/api/rate-limiter/rate-limiter.test.ts` (+0 -1) 📝 `packages/better-auth/src/api/routes/update-user.test.ts` (+1 -1) 📝 `packages/better-auth/src/db/utils.ts` (+1 -1) 📝 `packages/better-auth/src/plugins/api-key/routes/create-api-key.ts` (+2 -5) 📝 `packages/better-auth/src/plugins/api-key/routes/get-api-key.ts` (+1 -4) _...and 8 more files_ </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Enable Biome lint rule noTsIgnore and clean up suppressions across the repo. Replaced @ts-ignore with @ts-expect-error where errors are intentional, removed unnecessary suppressions, and made minor typing tweaks. No runtime changes. - **Refactors** - Set biome lint rule suspicious.noTsIgnore to error. - Replaced @ts-ignore with @ts-expect-error in adapters, API key routes, Kysely SQLite dialects, CLI, docs, demo, and tests. - Removed unused suppressions and adjusted types (e.g., safeJSONParse inputs, bun:sqlite type imports, number ID test types). <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 08:59:42 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#13545
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?