github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 16:11:53 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4176] [MERGED] fix(oidc-provider): handle string timestamps in user profile claims #13484

New Issue
Closed
opened 2026-04-13 08:58:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 08:58:07 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4176
Author: @Louis454545
Created: 8/23/2025
Status: ✅ Merged
Merged: 8/24/2025
Merged by: @Bekacru

Base: canary ← Head: fix/oidc-provider-timestamp-conversion

📝 Commits (1)

  • 4e82109 fix(oidc-provider): handle string timestamps in user profile claims

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 packages/better-auth/src/plugins/oidc-provider/index.ts (+1 -1)

📄 Description

Summary

Fixes an error in the OIDC provider when using timestamp fields with { mode: 'string' } configuration. The user.updatedAt.toISOString() call fails when updatedAt is already a string instead of a Date object.

  • Wraps user.updatedAt in new Date() before calling toISOString()
  • Ensures compatibility with both Date objects and string timestamps
  • Follows existing pattern used elsewhere in the codebase for timestamp handling

Test plan

  • Verified the fix resolves the "toISOString is not a function" error
  • Confirmed existing tests still pass with the change
  • Validated type safety - new Date() constructor accepts both Date and string inputs
  • Follows existing patterns in the codebase (line 812 already uses this approach)

Fixes #4159

Summary by cubic

Fixes a crash in the OIDC provider when updatedAt is a string (timestamp mode: 'string') by converting it to a Date before calling toISOString. Ensures updated_at in user profile claims is always valid. Fixes #4159.

  • Bug Fixes
    • Wrap user.updatedAt with new Date(...) before toISOString()
    • Supports both Date objects and string timestamps

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4176 **Author:** [@Louis454545](https://github.com/Louis454545) **Created:** 8/23/2025 **Status:** ✅ Merged **Merged:** 8/24/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `fix/oidc-provider-timestamp-conversion` --- ### 📝 Commits (1) - [`4e82109`](https://github.com/better-auth/better-auth/commit/4e82109be1cf3fc7252f519c88065b6930600f85) fix(oidc-provider): handle string timestamps in user profile claims ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/oidc-provider/index.ts` (+1 -1) </details> ### 📄 Description ## Summary Fixes an error in the OIDC provider when using timestamp fields with `{ mode: 'string' }` configuration. The `user.updatedAt.toISOString()` call fails when `updatedAt` is already a string instead of a Date object. - Wraps `user.updatedAt` in `new Date()` before calling `toISOString()` - Ensures compatibility with both Date objects and string timestamps - Follows existing pattern used elsewhere in the codebase for timestamp handling ## Test plan - [x] Verified the fix resolves the "toISOString is not a function" error - [x] Confirmed existing tests still pass with the change - [x] Validated type safety - `new Date()` constructor accepts both Date and string inputs - [x] Follows existing patterns in the codebase (line 812 already uses this approach) Fixes #4159 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fixes a crash in the OIDC provider when updatedAt is a string (timestamp mode: 'string') by converting it to a Date before calling toISOString. Ensures updated_at in user profile claims is always valid. Fixes #4159. - **Bug Fixes** - Wrap user.updatedAt with new Date(...) before toISOString() - Supports both Date objects and string timestamps <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 08:58:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#13484
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?