github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-31 19:36:46 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #3636] [MERGED] fix(username): add missing normalization #13173

New Issue
Closed
opened 2026-04-13 08:48:36 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 08:48:36 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/3636
Author: @bortoz
Created: 7/26/2025
Status: ✅ Merged
Merged: 9/12/2025
Merged by: @himself65

Base: canary ← Head: main

📝 Commits (3)

  • 745cc9d fix(username): add missing normalization
  • 792ebfc test: add
  • 148d1d8 Merge branch 'canary' into main

📊 Changes

2 files changed (+8 additions, -1 deletions)

View changed files

📝 packages/better-auth/src/plugins/username/index.ts (+1 -1)
📝 packages/better-auth/src/plugins/username/username.test.ts (+7 -0)

📄 Description

Summary by cubic

Fixed username normalization by using the correct normalizer function instead of toLowerCase. This ensures usernames are consistently processed during authentication.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/3636 **Author:** [@bortoz](https://github.com/bortoz) **Created:** 7/26/2025 **Status:** ✅ Merged **Merged:** 9/12/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `main` --- ### 📝 Commits (3) - [`745cc9d`](https://github.com/better-auth/better-auth/commit/745cc9d1ba4ad7017baa9dbc48e02f8400d908a9) fix(username): add missing normalization - [`792ebfc`](https://github.com/better-auth/better-auth/commit/792ebfcbc29d4ebff31a7b70cda5942004d639e1) test: add - [`148d1d8`](https://github.com/better-auth/better-auth/commit/148d1d8dbb9d43db9a47225820a3108d1dd148e5) Merge branch 'canary' into main ### 📊 Changes **2 files changed** (+8 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/username/index.ts` (+1 -1) 📝 `packages/better-auth/src/plugins/username/username.test.ts` (+7 -0) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Fixed username normalization by using the correct normalizer function instead of toLowerCase. This ensures usernames are consistently processed during authentication. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 08:48:36 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#13173
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?