github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #3438] [MERGED] feat: Add support for public clients in OIDC provider #13069

New Issue
Closed
opened 2026-04-13 08:43:52 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 08:43:52 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/3438
Author: @mohebifar
Created: 7/18/2025
Status: ✅ Merged
Merged: 7/18/2025
Merged by: @Bekacru

Base: v1.3 ← Head: fix/oidc-public-client

📝 Commits (1)

  • 8648ffd fix(oidc-provider): update client validation logic for public and confidential clients

📊 Changes

1 file changed (+20 additions, -3 deletions)

View changed files

📝 packages/better-auth/src/plugins/oidc-provider/index.ts (+20 -3)

📄 Description

This is a follow-up to: https://github.com/better-auth/better-auth/pull/3091

#3091 adds support for public clients to the MCP plugin's OIDC implementation but for oidc-provider plugin, it implements it partially.

The only thing missing in oidc-provider was skipping the !client_secret check which expects the client_secret to have been provided in the request body and causes a 401 error. We should conditionally run that condition only when the client type is not "public".

Similar to MCP, PKCE is gonna be mandatory i.e. code_verifier parameter is required

Summary by cubic

Added support for public clients in the OIDC provider by skipping client_secret checks and requiring PKCE for these clients.

  • New Features
    • Public clients can now authenticate without a client_secret.
    • PKCE (code_verifier) is required for public clients.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/3438 **Author:** [@mohebifar](https://github.com/mohebifar) **Created:** 7/18/2025 **Status:** ✅ Merged **Merged:** 7/18/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `v1.3` ← **Head:** `fix/oidc-public-client` --- ### 📝 Commits (1) - [`8648ffd`](https://github.com/better-auth/better-auth/commit/8648ffd2a6382b277ff97d35c729cc31051eb615) fix(oidc-provider): update client validation logic for public and confidential clients ### 📊 Changes **1 file changed** (+20 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/oidc-provider/index.ts` (+20 -3) </details> ### 📄 Description This is a follow-up to: https://github.com/better-auth/better-auth/pull/3091 #3091 adds support for public clients to the MCP plugin's OIDC implementation but for oidc-provider plugin, it implements it partially. The only thing missing in oidc-provider was skipping the `!client_secret` check which expects the client_secret to have been provided in the request body and causes a 401 error. We should conditionally run that condition only when the client type is not "public". Similar to MCP, PKCE is gonna be mandatory i.e. `code_verifier` parameter is required <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Added support for public clients in the OIDC provider by skipping client_secret checks and requiring PKCE for these clients. - **New Features** - Public clients can now authenticate without a client_secret. - PKCE (code_verifier) is required for public clients. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 08:43:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#13069
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?