github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-31 03:16:42 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #3020] [MERGED] Fix delete user fresh age check #12855

New Issue
Closed
opened 2026-04-13 08:38:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 08:38:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/3020
Author: @etler
Created: 6/14/2025
Status: ✅ Merged
Merged: 6/15/2025
Merged by: @Bekacru

Base: main ← Head: fix-delete-user-fresh-age-check

📝 Commits (1)

  • 6aa5e30 fix: deleteUser check session freshAge using ms instead of sec

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 packages/better-auth/src/api/routes/update-user.ts (+1 -1)

📄 Description

The deleteUser api route checks if a session is fresh before allowing the delete, but the freshAge config value was never converted from seconds to milliseconds.

With the default freshAge of 1 day, this means that the delete call session currently expires after 86 seconds.

This bug appears to have been around for a long time. Given how often time checks need to be made against config times, it would probably be better to create a utility function for doing time comparisons instead and refactor all existing time checks to use it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/3020 **Author:** [@etler](https://github.com/etler) **Created:** 6/14/2025 **Status:** ✅ Merged **Merged:** 6/15/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `fix-delete-user-fresh-age-check` --- ### 📝 Commits (1) - [`6aa5e30`](https://github.com/better-auth/better-auth/commit/6aa5e304fb1d64034a961123b577c20b1d3c5835) fix: deleteUser check session freshAge using ms instead of sec ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/api/routes/update-user.ts` (+1 -1) </details> ### 📄 Description The `deleteUser` api route checks if a session is fresh before allowing the delete, but the `freshAge` config value was never converted from seconds to milliseconds. With the default `freshAge` of 1 day, this means that the delete call session currently expires after 86 seconds. This bug appears to have been around for a long time. Given how often time checks need to be made against config times, it would probably be better to create a utility function for doing time comparisons instead and refactor all existing time checks to use it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 08:38:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#12855
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?